Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint 7.0 support #156

Merged
merged 1 commit into from Jan 2, 2024
Merged

fix: eslint 7.0 support #156

merged 1 commit into from Jan 2, 2024

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Jan 2, 2024

fixes #155

@aladdin-add aladdin-add marked this pull request as ready for review January 2, 2024 02:12
@aladdin-add aladdin-add marked this pull request as draft January 2, 2024 02:13
@aladdin-add aladdin-add force-pushed the fix/eslint-7.0 branch 2 times, most recently from d6b0a46 to 3a7c5fe Compare January 2, 2024 02:16
@aladdin-add aladdin-add marked this pull request as ready for review January 2, 2024 02:22
@scagood
Copy link

scagood commented Jan 2, 2024

It looks like we may need to bump the lowest eslint version to ^7.5.0 🤔

npm WARN Could not resolve dependency:
npm WARN peer eslint@">=8" from eslint-plugin-es-x@7.5.0
npm WARN node_modules/eslint-plugin-es-x
npm WARN   eslint-plugin-es-x@"^7.5.0" from the root project

@aladdin-add
Copy link
Author

It looks like we may need to bump the lowest eslint version to ^7.5.0 🤔

it could be a breaking to bump the required eslint version. The change is just a bugfix - regardless, the eslint v7 support will be likely dropped in v17.

@aladdin-add aladdin-add merged commit 2419888 into master Jan 2, 2024
11 checks passed
@aladdin-add aladdin-add deleted the fix/eslint-7.0 branch January 2, 2024 02:37
@SlyryD
Copy link

SlyryD commented Jan 3, 2024

It looks like we may need to bump the lowest eslint version to ^7.5.0 🤔

it could be a breaking to bump the required eslint version. The change is just a bugfix - regardless, the eslint v7 support will be likely dropped in v17.

What's the reason for dropping eslint v7 support in the next eslint-plugin-n release?

@aladdin-add
Copy link
Author

When we release major releases, we will consider dropping support for some of the older eslint, and will just support the latest 2 major versions (as we have done in the past).

Do you have any concerns?🤔

@SlyryD
Copy link

SlyryD commented Jan 3, 2024

I guess I was hoping to get the enhanced-resolve changes without having to migrate to eslint 8, but that's just because I'm trying to be lazy 😃 I also didn't realize there was an eslint 9 alpha release already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants