converted-esm/import-meta-resolve.js single-file CJS is unnecessarily huge due to non-ESM node_modules externals bundled by esbuild

[danielweck]

https://github.com/weiran-zsd/eslint-plugin-node/blob/master/lib/converted-esm/import-meta-resolve.js

Suggested fix: try esbuild externals
--external:./node_modules/*
(or be more selective if some externals are ESM instead of CJS dependencies)

See documentation: https://esbuild.github.io/api/#external

[danielweck]

Add externals to esbuild CLI:
https://github.com/weiran-zsd/eslint-plugin-node/blob/26448e08477ef1d6b55f304609bf038a0a970a3f/scripts/convert-pure-esm-to-cjs.js#L4

[danielweck]

For example, the bundled NPM packages builtins, semver, and yallist are all CJS, not ESM:
https://unpkg.com/browse/builtins/
https://unpkg.com/browse/semver/
https://unpkg.com/browse/yallist/
... so they should be externalised from the esbuild bundle, which otherwise is a huge payload of hard-to-review (and trust) code shipped to developers / users of the esling-plugin-node fork.

[danielweck]

ping @aladdin-add @voxpelli @giltayar
👍

Thanks for your work 😸

[danielweck]

From 109KB down to 32KB, just by externalising CJS NPM packages builtins yallist and semver:

npx esbuild --platform=node --external:builtins --external:yallist --external:semver --bundle node_modules/import-meta-resolve/lib/resolve.js > lib/converted-esm/import-meta-resolve.js

=>

[danielweck]

Pull Request: #10