Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: engines.node defaults to 16.0.0 #91

Merged
merged 4 commits into from Apr 23, 2023
Merged

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Mar 13, 2023

node.js < 13, v15 has been eol.
and node.js v14 will be eol in a few months.

refs: #42

TODO:

  • docs needs to be updated.

@aladdin-add aladdin-add requested a review from a team March 29, 2023 10:58
@aladdin-add aladdin-add marked this pull request as ready for review March 29, 2023 10:59
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to do some deduplication here.

I know it's in a way out of scope for this issue, but since we are changing the default version I think it's a good time to try and centralize the default and have it be defined in a single place and have the docs refer to that rather than document the default themselves.

What do you think?

docs/rules/no-deprecated-api.md Outdated Show resolved Hide resolved
docs/rules/no-unsupported-features/es-builtins.md Outdated Show resolved Hide resolved
@aladdin-add aladdin-add requested review from voxpelli and a team April 18, 2023 04:38
@aladdin-add aladdin-add force-pushed the feat/default-ecmaVersion branch 2 times, most recently from 633aae6 to 6f05061 Compare April 21, 2023 06:13
@aladdin-add
Copy link
Author

it's ready to go, other changes can be landed in following PRs(if needed).

@aladdin-add aladdin-add merged commit 075f0c5 into master Apr 23, 2023
9 checks passed
@aladdin-add aladdin-add deleted the feat/default-ecmaVersion branch April 23, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants