Documentation for detect-new-buffer is missing

[dskrvk]

This was added in #7 but somehow got removed later. In addition, that original description was a bit terse - can you include an explanation and/or a link as to why this is bad?

E.g. amqplib requires using a Buffer ctor with an arbitrary String argument to send messages. I could add a suppression, but want to understand the intent of this check.

[jesusprubio]

Summary
The documentation for the detect-new-buffer rule was deleted from the README but the rule is still in the codebase.

• Implementation: https://github.com/nodesecurity/eslint-plugin-security/blob/main/rules/detect-new-buffer.js

Still relevant?
Yes.

Next steps

• Re-add the rule documentation (https://github.com/nodesecurity/eslint-plugin-security/pull/7/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R26) in the proper line of the README: https://github.com/nodesecurity/eslint-plugin-security#detect-eval-with-expression

[jesusprubio]

I can pick this one once we start to fix things.

[hedtkeCqse]

Is the reason this is dangerous nodejs/node#4660 ?
As a side note: new Buffer is deprecated now.

[nzakas]

@hedtkeCqse yes, that's correct. I'll add that to the README.