Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ESLint 8.0.0 #278

Closed
ldrick opened this issue Oct 12, 2021 · 6 comments · Fixed by #227
Closed

Support for ESLint 8.0.0 #278

ldrick opened this issue Oct 12, 2021 · 6 comments · Fixed by #227
Labels
Accepted This issue or PR has been accepted. Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Released It's now live. Type: Maintenance Generic maintenance tasks, e.g., package updates.

Comments

@ldrick
Copy link

ldrick commented Oct 12, 2021

Suggestion

ESLint 8.0.0 dropped and brings some breaking changes.
https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0
Yesterday @typescript/eslint also published 5.0.0 to support new ESLint version.
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0

From the errors thrown, I see at least this dependency should be updated to support new ESLint:
"@typescript-eslint/experimental-utils"

Currently I am getting this error:

yarn lint

Oops! Something went wrong! :(

ESLint: 8.0.0

TypeError: Failed to load plugin 'functional' declared in 'package.json#overrides[1]': Class extends value undefined is not a constructor or null
Referenced from: [my]\package.json
    at Object.<anonymous> ([my]\.yarn\__virtual__\@typescript-eslint-experimental-utils-virtual-7774eb0b8d\0\cache\@typescript-eslint-experimental-utils-npm-4.28.1-ab919abf02-34a0dd8230.zip\node_modules\@typescript-eslint\experimental-utils\dist\ts-eslint\CLIEngine.js:12:34)
    at Module._compile ([my]\.yarn\cache\v8-compile-cache-npm-2.1.1-efff1ef0a4-692f6bc698.zip\node_modules\v8-compile-cache\v8-compile-cache.js:194:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.external_module_.Module._load [my]\.pnp.cjs:20312:14)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require ([my]\.yarn\cache\v8-compile-cache-npm-2.1.1-efff1ef0a4-692f6bc698.zip\node_modules\v8-compile-cache\v8-compile-cache.js:161:20)
    at Object.<anonymous> ([my]\.yarn\__virtual__\@typescript-eslint-experimental-utils-virtual-7774eb0b8d\0\cache\@typescript-eslint-experimental-utils-npm-4.28.1-ab919abf02-34a0dd8230.zip\node_modules\@typescript-eslint\experimental-utils\dist\ts-eslint\index.js:14:14)
    at Module._compile ([my]\.yarn\cache\v8-compile-cache-npm-2.1.1-efff1ef0a4-692f6bc698.zip\node_modules\v8-compile-cache\v8-compile-cache.js:194:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)

Whether or not this implies the requirement of a new major release, I am not aware.

@ldrick ldrick added Status: Triage This issue needs to be triaged. Type: Idea Marks an idea, which might be accepted and implemented. labels Oct 12, 2021
@ldrick ldrick changed the title Support for ESLint 8.0 Support for ESLint 8.0.0 Oct 12, 2021
@RebeccaStevens RebeccaStevens added Accepted This issue or PR has been accepted. Priority: High After critical issues are fixed, these should be dealt with before any further issues. Type: Maintenance Generic maintenance tasks, e.g., package updates. and removed Type: Idea Marks an idea, which might be accepted and implemented. Status: Triage This issue needs to be triaged. labels Oct 12, 2021
@m4thieulavoie
Copy link

I would be happy to handle this issue if help is needed here 👍 let me know!

@RebeccaStevens
Copy link
Collaborator

Thanks for the offer but I'm working on this atm. There should be a release later today.

@m4thieulavoie
Copy link

Thanks for the offer but I'm working on this atm. There should be a release later today.

Sorry I should've checked in the issue first, just closed my PRs. Thanks for looking into it 👍

@RebeccaStevens
Copy link
Collaborator

@m4thieulavoie Thanks anyway :)

@RebeccaStevens
Copy link
Collaborator

RebeccaStevens commented Oct 15, 2021

I've just released an RC version of the next version of this plugin which has support eslint 8 (this PR). Please feel free to test it out and if all is well, I'll release it in the next day or so.

You can add it with yarn add -D eslint-plugin-functional@rc

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted This issue or PR has been accepted. Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Released It's now live. Type: Maintenance Generic maintenance tasks, e.g., package updates.
Projects
None yet
3 participants