Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing build files #242

Closed
deraw opened this issue Oct 8, 2023 · 2 comments · Fixed by #243
Closed

Missing build files #242

deraw opened this issue Oct 8, 2023 · 2 comments · Fixed by #243
Labels
bug Something isn't working

Comments

@deraw
Copy link
Contributor

deraw commented Oct 8, 2023

On version 1.24.0, only the file index.cjs is present in the dist folder (see the package content on npm).
The files index.js and index.d.ts that are referenced in the package.json are not present.
@Shinigami92 Shinigami92 added the bug Something isn't working label Oct 8, 2023
@Shinigami92
Copy link
Collaborator

Yeah, whoops 😬
I forgot to add that to files property in package.json

Could you open a PR?
A can do a hotfix release tomorrow (I'm on my phone right now)

@deraw deraw mentioned this issue Oct 8, 2023
Merged
@deraw
Copy link
Contributor Author

deraw commented Oct 8, 2023

Yeah, whoops 😬 I forgot to add that to files property in package.json

Could you open a PR? A can do a hotfix release tomorrow (I'm on my phone right now)

Sure thing! #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing build files in package.json deraw/eslint-define-config
2 participants
@Shinigami92 @deraw