Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit message checks missing #145

Closed
mdjermanovic opened this issue Apr 2, 2021 · 3 comments
Closed

commit message checks missing #145

mdjermanovic opened this issue Apr 2, 2021 · 3 comments
Labels
Projects

Comments

@mdjermanovic
Copy link
Member

This PR was missing commit message check: eslint/eslint#14285. I think the check was there right after I opened the PR, but then disappeared.

Another PR with a missing commit message check: eslint/eslint#14271

Maybe this isn't only related to the commit message checks. For example, this PR had bot's warning about the PR title, but wasn't automatically assigned the "triage" label: eslint/eslint#14287

@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Apr 2, 2021
@nzakas
Copy link
Member

nzakas commented Apr 3, 2021

All of the PRs appear to have commit message comments, so it’s possible when a PR is re-checked that the status isn’t being reset.

@nzakas nzakas moved this from Needs Triage to Evaluating in Triage Apr 3, 2021
@nzakas
Copy link
Member

nzakas commented May 25, 2021

Have we seen this recently at all?

@nzakas
Copy link
Member

nzakas commented Sep 16, 2021

It looks like this has been working fine, so closing.

@nzakas nzakas closed this as completed Sep 16, 2021
Triage automation moved this from Evaluating to Complete Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Triage
Complete
Development

No branches or pull requests

2 participants