Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Increase code coverage #64

Merged
merged 1 commit into from Apr 29, 2017
Merged

Chore: Increase code coverage #64

merged 1 commit into from Apr 29, 2017

Conversation

btmills
Copy link
Member

@btmills btmills commented Apr 29, 2017 •
edited

馃毀 This depends on #63, which should be merged first, and then I'll update the base branch for this PR back to master. 馃毀 Edit: Done

@wooorm
Copy link
Sponsor Contributor

wooorm commented Apr 29, 2017

Whoops, thanks for fixing!

@btmills btmills changed the base branch from makefile to master April 29, 2017 22:42
@btmills
Copy link
Member Author

btmills commented Apr 29, 2017

@wooorm these tests were missing before you made any changes, so you're completely off the hook 馃槄 I had started working on #63, which added code coverage reports, last weekend, which is when I discovered these missing cases that were in the code all along.

@btmills btmills merged commit cc7deea into master Apr 29, 2017
@btmills btmills deleted the coverage branch April 29, 2017 22:47
@wooorm
Copy link
Sponsor Contributor

wooorm commented Apr 30, 2017

Ah, good! 馃槍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btmills @wooorm @not-an-aardvark