/
no-useless-concat.js
120 lines (110 loc) · 3.23 KB
/
no-useless-concat.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
/**
* @fileoverview disallow unnecessary concatenation of literals or template literals
* @author Henry Zhu
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require("../../../lib/rules/no-useless-concat"),
{ RuleTester } = require("../../../lib/rule-tester");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const ruleTester = new RuleTester();
ruleTester.run("no-useless-concat", rule, {
valid: [
"var a = 1 + 1;",
"var a = 1 * '2';",
"var a = 1 - 2;",
"var a = foo + bar;",
"var a = 'foo' + bar;",
"var foo = 'foo' +\n 'bar';",
// https://github.com/eslint/eslint/issues/3575
"var string = (number + 1) + 'px';",
"'a' + 1",
"1 + '1'",
{ code: "1 + `1`", parserOptions: { ecmaVersion: 6 } },
{ code: "`1` + 1", parserOptions: { ecmaVersion: 6 } },
{ code: "(1 + +2) + `b`", parserOptions: { ecmaVersion: 6 } }
],
invalid: [
{
code: "'a' + 'b'",
errors: [
{
messageId: "unexpectedConcat",
line: 1,
column: 5,
endLine: 1,
endColumn: 6
}
]
},
{
code: "'a' +\n'b' + 'c'",
errors: [
{
messageId: "unexpectedConcat",
line: 2,
column: 5,
endLine: 2,
endColumn: 6
}
]
},
{
code: "foo + 'a' + 'b'",
errors: [
{ messageId: "unexpectedConcat" }
]
},
{
code: "'a' + 'b' + 'c'",
errors: [
{
messageId: "unexpectedConcat",
line: 1,
column: 5,
endLine: 1,
endColumn: 6
},
{
messageId: "unexpectedConcat",
line: 1,
column: 11,
endLine: 1,
endColumn: 12
}
]
},
{
code: "(foo + 'a') + ('b' + 'c')",
errors: [
{ column: 13, messageId: "unexpectedConcat" },
{ column: 20, messageId: "unexpectedConcat" }
]
},
{
code: "`a` + 'b'",
parserOptions: { ecmaVersion: 6 },
errors: [
{ messageId: "unexpectedConcat" }
]
},
{
code: "`a` + `b`",
parserOptions: { ecmaVersion: 6 },
errors: [
{ messageId: "unexpectedConcat" }
]
},
{
code: "foo + `a` + `b`",
parserOptions: { ecmaVersion: 6 },
errors: [
{ messageId: "unexpectedConcat" }
]
}
]
});