no-useless-computed-key.js

/**
 * @fileoverview Tests for no-useless-computed-key rule.
 * @author Burak Yigit Kaya
 */

"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const rule = require("../../../lib/rules/no-useless-computed-key"),
    { RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });

ruleTester.run("no-useless-computed-key", rule, {
    valid: [
        "({ 'a': 0, b(){} })",
        "({ [x]: 0 });",
        "({ a: 0, [b](){} })",
        "({ ['__proto__']: [] })",
        { code: "class Foo { 'a'() {} }", options: [{ enforceForClassMembers: true }] },
        { code: "class Foo { [x]() {} }", options: [{ enforceForClassMembers: true }] },
        { code: "class Foo { ['constructor']() {} }", options: [{ enforceForClassMembers: true }] },
        { code: "class Foo { static ['prototype']() {} }", options: [{ enforceForClassMembers: true }] },
        { code: "(class { 'a'() {} })", options: [{ enforceForClassMembers: true }] },
        { code: "(class { [x]() {} })", options: [{ enforceForClassMembers: true }] },
        { code: "(class { ['constructor']() {} })", options: [{ enforceForClassMembers: true }] },
        { code: "(class { static ['prototype']() {} })", options: [{ enforceForClassMembers: true }] },
        "class Foo { ['x']() {} }",
        "(class { ['x']() {} })",
        "class Foo { static ['constructor']() {} }",
        "class Foo { ['prototype']() {} }",
        { code: "class Foo { ['x']() {} }", options: [{ enforceForClassMembers: false }] },
        { code: "(class { ['x']() {} })", options: [{ enforceForClassMembers: false }] },
        { code: "class Foo { static ['constructor']() {} }", options: [{ enforceForClassMembers: false }] },
        { code: "class Foo { ['prototype']() {} }", options: [{ enforceForClassMembers: false }] }
    ],
    invalid: [
        {
            code: "({ ['0']: 0 })",
            output: "({ '0': 0 })",
            errors: [{
                message: "Unnecessarily computed property ['0'] found.", type: "Property"
            }]
        }, {
            code: "({ ['0+1,234']: 0 })",
            output: "({ '0+1,234': 0 })",
            errors: [{
                message: "Unnecessarily computed property ['0+1,234'] found.", type: "Property"
            }]
        }, {
            code: "({ [0]: 0 })",
            output: "({ 0: 0 })",
            errors: [{
                message: "Unnecessarily computed property [0] found.", type: "Property"
            }]
        }, {
            code: "({ ['x']: 0 })",
            output: "({ 'x': 0 })",
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "Property"
            }]
        }, {
            code: "({ ['x']() {} })",
            output: "({ 'x'() {} })",
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "Property"
            }]
        }, {
            code: "({ [/* this comment prevents a fix */ 'x']: 0 })",
            output: null,
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "Property"
            }]
        }, {
            code: "({ ['x' /* this comment also prevents a fix */]: 0 })",
            output: null,
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "Property"
            }]
        }, {
            code: "({ [('x')]: 0 })",
            output: "({ 'x': 0 })",
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "Property"
            }]
        }, {
            code: "({ *['x']() {} })",
            output: "({ *'x'() {} })",
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "Property"
            }]
        }, {
            code: "({ async ['x']() {} })",
            output: "({ async 'x'() {} })",
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "Property"
            }]
        }, {
            code: "({ get[.2]() {} })",
            output: "({ get.2() {} })",
            errors: [{
                message: "Unnecessarily computed property [.2] found.", type: "Property"
            }]
        }, {
            code: "({ set[.2](value) {} })",
            output: "({ set.2(value) {} })",
            errors: [{
                message: "Unnecessarily computed property [.2] found.", type: "Property"
            }]
        }, {
            code: "({ async[.2]() {} })",
            output: "({ async.2() {} })",
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property [.2] found.", type: "Property"
            }]
        }, {
            code: "({ [2]() {} })",
            output: "({ 2() {} })",
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ get [2]() {} })",
            output: "({ get 2() {} })",
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ set [2](value) {} })",
            output: "({ set 2(value) {} })",
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ async [2]() {} })",
            output: "({ async 2() {} })",
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ get[2]() {} })",
            output: "({ get 2() {} })",
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ set[2](value) {} })",
            output: "({ set 2(value) {} })",
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ async[2]() {} })",
            output: "({ async 2() {} })",
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ get['foo']() {} })",
            output: "({ get'foo'() {} })",
            errors: [{
                message: "Unnecessarily computed property ['foo'] found.", type: "Property"
            }]
        }, {
            code: "({ *[2]() {} })",
            output: "({ *2() {} })",
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "({ async*[2]() {} })",
            output: "({ async*2() {} })",
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "Property"
            }]
        }, {
            code: "class Foo { ['0']() {} }",
            output: "class Foo { '0'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['0'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { ['0+1,234']() {} }",
            output: "class Foo { '0+1,234'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['0+1,234'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { ['x']() {} }",
            output: "class Foo { 'x'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { [/* this comment prevents a fix */ 'x']() {} }",
            output: null,
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { ['x' /* this comment also prevents a fix */]() {} }",
            output: null,
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { [('x')]() {} }",
            output: "class Foo { 'x'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { *['x']() {} }",
            output: "class Foo { *'x'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { async ['x']() {} }",
            output: "class Foo { async 'x'() {} }",
            options: [{ enforceForClassMembers: true }],
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { get[.2]() {} }",
            output: "class Foo { get.2() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [.2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { set[.2](value) {} }",
            output: "class Foo { set.2(value) {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [.2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { async[.2]() {} }",
            output: "class Foo { async.2() {} }",
            options: [{ enforceForClassMembers: true }],
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property [.2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { [2]() {} }",
            output: "class Foo { 2() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { get [2]() {} }",
            output: "class Foo { get 2() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { set [2](value) {} }",
            output: "class Foo { set 2(value) {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { async [2]() {} }",
            output: "class Foo { async 2() {} }",
            options: [{ enforceForClassMembers: true }],
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { get[2]() {} }",
            output: "class Foo { get 2() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { set[2](value) {} }",
            output: "class Foo { set 2(value) {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { async[2]() {} }",
            output: "class Foo { async 2() {} }",
            options: [{ enforceForClassMembers: true }],
            parserOptions: { ecmaVersion: 8 },
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { get['foo']() {} }",
            output: "class Foo { get'foo'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['foo'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { *[2]() {} }",
            output: "class Foo { *2() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { async*[2]() {} }",
            output: "class Foo { async*2() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property [2] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { static ['constructor']() {} }",
            output: "class Foo { static 'constructor'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['constructor'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "class Foo { ['prototype']() {} }",
            output: "class Foo { 'prototype'() {} }",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['prototype'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "(class { ['x']() {} })",
            output: "(class { 'x'() {} })",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['x'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "(class { static ['constructor']() {} })",
            output: "(class { static 'constructor'() {} })",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['constructor'] found.", type: "MethodDefinition"
            }]
        }, {
            code: "(class { ['prototype']() {} })",
            output: "(class { 'prototype'() {} })",
            options: [{ enforceForClassMembers: true }],
            errors: [{
                message: "Unnecessarily computed property ['prototype'] found.", type: "MethodDefinition"
            }]
        }
    ]
});