/
no-constructor-return.js
61 lines (50 loc) · 1.76 KB
/
no-constructor-return.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
/**
* @fileoverview Rule to disallow returning value from constructor.
* @author Pig Fang <https://github.com/g-plane>
*/
"use strict";
const astUtils = require("./utils/ast-utils");
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
module.exports = {
meta: {
type: "suggestion",
docs: {
description: "disallow returning value from constructor",
category: "Best Practices",
recommended: false,
url: "https://eslint.org/docs/rules/no-constructor-return"
},
schema: {},
fixable: null,
messages: {
unexpected: "Unexpected return statement in constructor."
}
},
create(context) {
return {
"MethodDefinition[kind='constructor'] ReturnStatement"(node) {
const ancestors = context.getAncestors().reverse();
const ctorIndex = ancestors.findIndex(
ancestor => ancestor.type === "MethodDefinition" && ancestor.kind === "constructor"
);
const upperFnIndex = ancestors.findIndex(astUtils.isFunction);
if (~upperFnIndex && upperFnIndex < ctorIndex - 1) {
return;
}
if (
ancestors[2] &&
ancestors[2].type === "MethodDefinition" &&
ancestors[2].kind === "constructor" ||
node.argument
) {
context.report({
node,
messageId: "unexpected"
});
}
}
};
}
};