From 0052374035672efe9129343fc00ee51a4c288ff3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=94=AF=E7=84=B6?= Date: Tue, 4 Jul 2023 21:49:58 +0800 Subject: [PATCH] chore: move jsdoc settings to eslint-config-eslint (#17338) --- .eslintrc.js | 10 ---------- eslint.config.js | 10 ---------- packages/eslint-config-eslint/eslintrc.js | 1 + packages/eslint-config-eslint/index.js | 1 + 4 files changed, 2 insertions(+), 20 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 79812915fbf..7757f21bd2b 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -67,16 +67,6 @@ module.exports = { parserOptions: { ecmaVersion: 2021 }, - - /* - * it fixes eslint-plugin-jsdoc's reports: "Invalid JSDoc tag name "template" jsdoc/check-tag-names" - * refs: https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names - */ - settings: { - jsdoc: { - mode: "typescript" - } - }, rules: { "internal-rules/multiline-comment-style": "error" }, diff --git a/eslint.config.js b/eslint.config.js index 95612e901ca..09497a915b6 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -100,16 +100,6 @@ module.exports = [ languageOptions: { ecmaVersion: "latest" }, - - /* - * it fixes eslint-plugin-jsdoc's reports: "Invalid JSDoc tag name "template" jsdoc/check-tag-names" - * refs: https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names - */ - settings: { - jsdoc: { - mode: "typescript" - } - }, rules: { "internal-rules/multiline-comment-style": "error" } diff --git a/packages/eslint-config-eslint/eslintrc.js b/packages/eslint-config-eslint/eslintrc.js index a821ab0a07c..31ce7f252c0 100644 --- a/packages/eslint-config-eslint/eslintrc.js +++ b/packages/eslint-config-eslint/eslintrc.js @@ -18,6 +18,7 @@ module.exports = { plugins: ["unicorn"], settings: { jsdoc: { + mode: "typescript", tagNamePreference: { file: "fileoverview", augments: "extends", diff --git a/packages/eslint-config-eslint/index.js b/packages/eslint-config-eslint/index.js index 1f629c5cd83..4057d6d944c 100644 --- a/packages/eslint-config-eslint/index.js +++ b/packages/eslint-config-eslint/index.js @@ -278,6 +278,7 @@ const jsConfigs = [js.configs.recommended, { const jsdocConfigs = [jsdoc.configs.recommended, { settings: { jsdoc: { + mode: "typescript", tagNamePreference: { file: "fileoverview", augments: "extends",