From 0243549db4d237cb78e720d55a9cae89b91f6830 Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Tue, 10 Mar 2020 18:36:03 +0100 Subject: [PATCH] Fix: camelcase false positive with computed property (fixes #13022) (#13023) --- lib/rules/camelcase.js | 2 +- tests/lib/rules/camelcase.js | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/rules/camelcase.js b/lib/rules/camelcase.js index a06c7f94042..cd607114e60 100644 --- a/lib/rules/camelcase.js +++ b/lib/rules/camelcase.js @@ -186,7 +186,7 @@ module.exports = { const assignmentKeyEqualsValue = node.parent.key.name === node.parent.value.name; - if (isUnderscored(name) && node.parent.computed) { + if (nameIsUnderscored && node.parent.computed) { report(node); } diff --git a/tests/lib/rules/camelcase.js b/tests/lib/rules/camelcase.js index dffdf11da00..21f280adb35 100644 --- a/tests/lib/rules/camelcase.js +++ b/tests/lib/rules/camelcase.js @@ -91,6 +91,14 @@ ruleTester.run("camelcase", rule, { code: "obj.foo_bar = function(){};", options: [{ properties: "never" }] }, + { + code: "const { ['foo']: _foo } = obj;", + parserOptions: { ecmaVersion: 6 } + }, + { + code: "const { [_foo_]: foo } = obj;", + parserOptions: { ecmaVersion: 6 } + }, { code: "var { category_id } = query;", options: [{ ignoreDestructuring: true }],