From 0acdefb97f35bb09db2910540c70dc377a01ad62 Mon Sep 17 00:00:00 2001
From: James George <jamesgeorge998001@gmail.com>
Date: Sat, 31 Aug 2019 01:09:32 +0530
Subject: [PATCH] Chore: refactor code (#12113)

* Chore: refactor code

* Fix: minor tweak

* Minor tweak

* Fix: lint

* Fix: minor tweak

have deps as a Set rather than an array

* Fix: tweak

* fix: typo
---
 lib/init/npm-utils.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/init/npm-utils.js b/lib/init/npm-utils.js
index 3a680aae924..7fe7c6e7d59 100644
--- a/lib/init/npm-utils.js
+++ b/lib/init/npm-utils.js
@@ -98,7 +98,7 @@ function fetchPeerDependencies(packageName) {
  *                                        and values are booleans indicating installation.
  */
 function check(packages, opt) {
-    let deps = [];
+    const deps = new Set();
     const pkgJson = (opt) ? findPackageJson(opt.startDir) : findPackageJson();
     let fileJson;
 
@@ -119,14 +119,14 @@ function check(packages, opt) {
         throw error;
     }
 
-    if (opt.devDependencies && typeof fileJson.devDependencies === "object") {
-        deps = deps.concat(Object.keys(fileJson.devDependencies));
-    }
-    if (opt.dependencies && typeof fileJson.dependencies === "object") {
-        deps = deps.concat(Object.keys(fileJson.dependencies));
-    }
+    ["dependencies", "devDependencies"].forEach(key => {
+        if (opt[key] && typeof fileJson[key] === "object") {
+            Object.keys(fileJson[key]).forEach(dep => deps.add(dep));
+        }
+    });
+
     return packages.reduce((status, pkg) => {
-        status[pkg] = deps.indexOf(pkg) !== -1;
+        status[pkg] = deps.has(pkg);
         return status;
     }, {});
 }