Navigation Menu

Skip to content

Commit

Permalink
Chore: Adopt eslint-plugin/require-meta-docs-description internally (
Browse files Browse the repository at this point in the history
…#12762)

* Upgrade: eslint-plugin-eslint-plugin to 2.2.1

https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/CHANGELOG.md#v221-2020-01-17

* Chore: enable `eslint-plugin/require-meta-docs-description` rule internally

https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-docs-description.md

* Chore: delete `internal-rules/consistent-docs-description`

Replaced by `eslint-plugin/require-meta-docs-description`:

https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-docs-description.md
  • Loading branch information
bmish authored and kaicataldo committed Jan 27, 2020
1 parent aea1729 commit 10a79a6
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 401 deletions.
4 changes: 2 additions & 2 deletions .eslintrc.js
Expand Up @@ -28,6 +28,7 @@ module.exports = {
"eslint-plugin/prefer-output-null": "error",
"eslint-plugin/prefer-placeholders": "error",
"eslint-plugin/report-message-format": ["error", "[^a-z].*\\.$"],
"eslint-plugin/require-meta-docs-description": "error",
"eslint-plugin/require-meta-type": "error",
"eslint-plugin/test-case-property-ordering": [
"error",
Expand All @@ -53,8 +54,7 @@ module.exports = {
files: ["lib/rules/*", "tools/internal-rules/*"],
excludedFiles: ["index.js"],
rules: {
"internal-rules/no-invalid-meta": "error",
"internal-rules/consistent-docs-description": "error"
"internal-rules/no-invalid-meta": "error"

/*
* TODO: enable it when all the rules using meta.messages
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -96,7 +96,7 @@
"ejs": "^2.6.1",
"eslint": "file:.",
"eslint-config-eslint": "file:packages/eslint-config-eslint",
"eslint-plugin-eslint-plugin": "^2.0.1",
"eslint-plugin-eslint-plugin": "^2.2.1",
"eslint-plugin-internal-rules": "file:tools/internal-rules",
"eslint-plugin-jsdoc": "^15.9.5",
"eslint-plugin-node": "^9.0.0",
Expand Down
264 changes: 0 additions & 264 deletions tests/tools/internal-rules/consistent-docs-description.js

This file was deleted.

0 comments on commit 10a79a6

Please sign in to comment.