Fix: no-new-symbol false positive with Symbol as an argument (#13337)

eslint · May 22, 2020 · 1710296 · 1710296
1 parent cc01451
commit 1710296
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/rules/no-new-symbol.js b/lib/rules/no-new-symbol.js
@@ -37,8 +37,9 @@ module.exports = {
                 if (variable && variable.defs.length === 0) {
                     variable.references.forEach(ref => {
                         const node = ref.identifier;
+                        const parent = node.parent;
 
-                        if (node.parent && node.parent.type === "NewExpression") {
+                        if (parent && parent.type === "NewExpression" && parent.callee === node) {
                             context.report({
                                 node,
                                 messageId: "noNewSymbol"

diff --git a/tests/lib/rules/no-new-symbol.js b/tests/lib/rules/no-new-symbol.js
@@ -22,7 +22,9 @@ ruleTester.run("no-new-symbol", rule, {
     valid: [
         "var foo = Symbol('foo');",
         "function bar(Symbol) { var baz = new Symbol('baz');}",
-        "function Symbol() {} new Symbol();"
+        "function Symbol() {} new Symbol();",
+        "new foo(Symbol);",
+        "new foo(bar, Symbol);"
     ],
     invalid: [
         {