From 1a078b9166f29cb3760435ddbc1a0da4a0974d4a Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Sat, 30 Jan 2021 04:22:13 +0100 Subject: [PATCH] Update: check ternary `:` even if `?` was reported in space-infix-ops (#13963) --- lib/rules/space-infix-ops.js | 4 +- tests/lib/rules/space-infix-ops.js | 72 ++++++++++++++++++++++++++---- 2 files changed, 66 insertions(+), 10 deletions(-) diff --git a/lib/rules/space-infix-ops.js b/lib/rules/space-infix-ops.js index 471c22210eb..3c550984fc6 100644 --- a/lib/rules/space-infix-ops.js +++ b/lib/rules/space-infix-ops.js @@ -132,7 +132,9 @@ module.exports = { if (nonSpacedConsequentNode) { report(node, nonSpacedConsequentNode); - } else if (nonSpacedAlternateNode) { + } + + if (nonSpacedAlternateNode) { report(node, nonSpacedAlternateNode); } } diff --git a/tests/lib/rules/space-infix-ops.js b/tests/lib/rules/space-infix-ops.js index 2e9edbaa8cf..2e6f423e919 100644 --- a/tests/lib/rules/space-infix-ops.js +++ b/tests/lib/rules/space-infix-ops.js @@ -161,15 +161,69 @@ ruleTester.run("space-infix-ops", rule, { }, { code: "a?b:c", - output: "a ? b:c", - errors: [{ - messageId: "missingSpace", - data: { operator: "?" }, - type: "ConditionalExpression", - line: 1, - column: 2, - endColumn: 3 - }] + output: "a ? b : c", + errors: [ + { + messageId: "missingSpace", + data: { operator: "?" }, + type: "ConditionalExpression", + line: 1, + column: 2, + endColumn: 3 + }, + { + messageId: "missingSpace", + data: { operator: ":" }, + type: "ConditionalExpression", + line: 1, + column: 4, + endColumn: 5 + } + ] + }, + { + code: "a? b :c", + output: "a ? b : c", + errors: [ + { + messageId: "missingSpace", + data: { operator: "?" }, + type: "ConditionalExpression", + line: 1, + column: 2, + endColumn: 3 + }, + { + messageId: "missingSpace", + data: { operator: ":" }, + type: "ConditionalExpression", + line: 1, + column: 6, + endColumn: 7 + } + ] + }, + { + code: "a ?b: c", + output: "a ? b : c", + errors: [ + { + messageId: "missingSpace", + data: { operator: "?" }, + type: "ConditionalExpression", + line: 1, + column: 3, + endColumn: 4 + }, + { + messageId: "missingSpace", + data: { operator: ":" }, + type: "ConditionalExpression", + line: 1, + column: 5, + endColumn: 6 + } + ] }, { code: "a?b : c",