Fix: fix inconsistently works option in no-extra-parens (fixes #12717) (

#12843)
eslint · Feb 14, 2020 · 1f1424c · 1f1424c
1 parent b5adcaa
commit 1f1424c
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 5 deletions.
diff --git a/lib/rules/no-extra-parens.js b/lib/rules/no-extra-parens.js
@@ -702,8 +702,7 @@ module.exports = {
                 }
 
                 if (node.body.type === "ConditionalExpression" &&
-                    IGNORE_ARROW_CONDITIONALS &&
-                    !isParenthesisedTwice(node.body)
+                    IGNORE_ARROW_CONDITIONALS
                 ) {
                     return;
                 }

diff --git a/tests/lib/rules/no-extra-parens.js b/tests/lib/rules/no-extra-parens.js
@@ -244,19 +244,28 @@ ruleTester.run("no-extra-parens", rule, {
 
         // "functions" enables reports for function nodes only
         { code: "(0)", options: ["functions"] },
+        { code: "((0))", options: ["functions"] },
         { code: "a + (b * c)", options: ["functions"] },
+        { code: "a + ((b * c))", options: ["functions"] },
         { code: "(a)(b)", options: ["functions"] },
+        { code: "((a))(b)", options: ["functions"] },
         { code: "a, (b = c)", options: ["functions"] },
+        { code: "a, ((b = c))", options: ["functions"] },
         { code: "for(a in (0));", options: ["functions"] },
+        { code: "for(a in ((0)));", options: ["functions"] },
         { code: "var a = (b = c)", options: ["functions"] },
+        { code: "var a = ((b = c))", options: ["functions"] },
         { code: "_ => (a = 0)", options: ["functions"] },
+        { code: "_ => ((a = 0))", options: ["functions"] },
 
         // ["all", { conditionalAssign: false }] enables extra parens around conditional assignments
         { code: "while ((foo = bar())) {}", options: ["all", { conditionalAssign: false }] },
         { code: "if ((foo = bar())) {}", options: ["all", { conditionalAssign: false }] },
         { code: "do; while ((foo = bar()))", options: ["all", { conditionalAssign: false }] },
         { code: "for (;(a = b););", options: ["all", { conditionalAssign: false }] },
         { code: "var a = ((b = c)) ? foo : bar;", options: ["all", { conditionalAssign: false }] },
+        { code: "while (((foo = bar()))) {}", options: ["all", { conditionalAssign: false }] },
+        { code: "var a = (((b = c))) ? foo : bar;", options: ["all", { conditionalAssign: false }] },
 
         // ["all", { nestedBinaryExpressions: false }] enables extra parens around conditional assignments
         { code: "a + (b * c)", options: ["all", { nestedBinaryExpressions: false }] },
@@ -369,6 +378,7 @@ ruleTester.run("no-extra-parens", rule, {
 
         // ["all", { ignoreJSX: "all" }]
         { code: "const Component = (<div />)", options: ["all", { ignoreJSX: "all" }] },
+        { code: "const Component = ((<div />))", options: ["all", { ignoreJSX: "all" }] },
         {
             code: [
                 "const Component = (<>",
@@ -377,6 +387,14 @@ ruleTester.run("no-extra-parens", rule, {
             ].join("\n"),
             options: ["all", { ignoreJSX: "all" }]
         },
+        {
+            code: [
+                "const Component = ((<>",
+                "  <p />",
+                "</>));"
+            ].join("\n"),
+            options: ["all", { ignoreJSX: "all" }]
+        },
         {
             code: [
                 "const Component = (<div>",
@@ -403,6 +421,7 @@ ruleTester.run("no-extra-parens", rule, {
 
         // ["all", { ignoreJSX: "single-line" }]
         { code: "const Component = (<div />);", options: ["all", { ignoreJSX: "single-line" }] },
+        { code: "const Component = ((<div />));", options: ["all", { ignoreJSX: "single-line" }] },
         {
             code: [
                 "const Component = (",
@@ -430,6 +449,16 @@ ruleTester.run("no-extra-parens", rule, {
             ].join("\n"),
             options: ["all", { ignoreJSX: "multi-line" }]
         },
+        {
+            code: [
+                "const Component = ((",
+                "<div>",
+                "  <p />",
+                "</div>",
+                "));"
+            ].join("\n"),
+            options: ["all", { ignoreJSX: "multi-line" }]
+        },
         {
             code: [
                 "const Component = (<div>",
@@ -459,13 +488,15 @@ ruleTester.run("no-extra-parens", rule, {
         // ["all", { enforceForArrowConditionals: false }]
         { code: "var a = b => 1 ? 2 : 3", options: ["all", { enforceForArrowConditionals: false }] },
         { code: "var a = (b) => (1 ? 2 : 3)", options: ["all", { enforceForArrowConditionals: false }] },
+        { code: "var a = (b) => ((1 ? 2 : 3))", options: ["all", { enforceForArrowConditionals: false }] },
 
         // ["all", { enforceForSequenceExpressions: false }]
         { code: "(a, b)", options: ["all", { enforceForSequenceExpressions: false }] },
         { code: "((a, b))", options: ["all", { enforceForSequenceExpressions: false }] },
         { code: "(foo(), bar());", options: ["all", { enforceForSequenceExpressions: false }] },
         { code: "((foo(), bar()));", options: ["all", { enforceForSequenceExpressions: false }] },
         { code: "if((a, b)){}", options: ["all", { enforceForSequenceExpressions: false }] },
+        { code: "if(((a, b))){}", options: ["all", { enforceForSequenceExpressions: false }] },
         { code: "while ((val = foo(), val < 10));", options: ["all", { enforceForSequenceExpressions: false }] },
 
         // ["all", { enforceForNewInMemberExpressions: false }]
@@ -1122,12 +1153,10 @@ ruleTester.run("no-extra-parens", rule, {
                 }
             ]
         },
-
-        // ["all", { enforceForArrowConditionals: false }]
         {
             code: "var a = (b) => ((1 ? 2 : 3))",
             output: "var a = (b) => (1 ? 2 : 3)",
-            options: ["all", { enforceForArrowConditionals: false }],
+            options: ["all", { enforceForArrowConditionals: true }],
             errors: [
                 {
                     messageId: "unexpected"