Skip to content

Commit

Permalink
chore: suppress a Node.js deprecation warning (#16398)
Browse files Browse the repository at this point in the history
Follow up nodejs/node#37302.

This PR suppress the following Node.js warning.

```console
% node -v
v18.10.0
% cd path/to/eslint
% node Makefile mocha
Running unit tests
(snip)

(node:63796) [DEP0147] DeprecationWarning: In future versions of Node.js,
fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
```

And added compatibility condition to prevent the following error when using Node.js 14.13.1 or lower.

```console
% node -v
v14.13.1
% npx mocha tests/lib/eslint/flat-eslint.js
(snip)

1) FlatESLint
     lintFiles()
       multiple processors
         "after each" hook for "should lint only JavaScript blocks.":
     TypeError: fsp.rm is not a function
```
  • Loading branch information
koic committed Oct 10, 2022
1 parent 94ba68d commit 232d291
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion tests/lib/eslint/flat-eslint.js
Expand Up @@ -2607,7 +2607,17 @@ describe("FlatESLint", () => {
let id;

beforeEach(() => (id = Date.now().toString()));
afterEach(async () => fsp.rmdir(root, { recursive: true, force: true }));

/*
* `fs.rmdir(path, { recursive: true })` is deprecated and will be removed.
* Use `fs.rm(path, { recursive: true })` instead.
* When supporting Node.js 14.14.0+, the compatibility condition can be removed for `fs.rmdir`.
*/
if (typeof fsp.rm === "function") {
afterEach(async () => fsp.rm(root, { recursive: true, force: true }));
} else {
afterEach(async () => fsp.rmdir(root, { recursive: true, force: true }));
}

it("should lint only JavaScript blocks.", async () => {
const teardown = createCustomTeardown({
Expand Down

0 comments on commit 232d291

Please sign in to comment.