Fix: no-extra-parens export default sequence expression false positive (

#13096)
eslint · Apr 6, 2020 · 301b450 · 301b450
1 parent af4472f
commit 301b450
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 3 deletions.
diff --git a/lib/rules/no-extra-parens.js b/lib/rules/no-extra-parens.js
@@ -560,7 +560,11 @@ module.exports = {
                 tokensToIgnore.add(secondToken);
             }
 
-            if (hasExcessParens(node)) {
+            const hasExtraParens = node.parent.type === "ExportDefaultDeclaration"
+                ? hasExcessParensWithPrecedence(node, PRECEDENCE_OF_ASSIGNMENT_EXPR)
+                : hasExcessParens(node);
+
+            if (hasExtraParens) {
                 report(node);
             }
         }

diff --git a/tests/lib/rules/no-extra-parens.js b/tests/lib/rules/no-extra-parens.js
@@ -530,13 +530,17 @@ ruleTester.run("no-extra-parens", rule, {
         "() => ({ foo: 1 }).foo",
         "() => ({ foo: 1 }.foo().bar).baz.qux()",
         "() => ({ foo: 1 }.foo().bar + baz)",
+        {
+            code: "export default (a, b)",
+            parserOptions: { sourceType: "module" }
+        },
         {
             code: "export default (function(){}).foo",
-            parserOptions: { ecmaVersion: 6, sourceType: "module" }
+            parserOptions: { sourceType: "module" }
         },
         {
             code: "export default (class{}).foo",
-            parserOptions: { ecmaVersion: 6, sourceType: "module" }
+            parserOptions: { sourceType: "module" }
         },
         "({}).hasOwnProperty.call(foo, bar)",
         "({}) ? foo() : bar()",
@@ -1358,6 +1362,55 @@ ruleTester.run("no-extra-parens", rule, {
             "UpdateExpression",
             1
         ),
+        invalid(
+            "export default ((a, b))",
+            "export default (a, b)",
+            "SequenceExpression",
+            1,
+            { parserOptions: { sourceType: "module" } }
+        ),
+        invalid(
+            "export default (() => {})",
+            "export default () => {}",
+            "ArrowFunctionExpression",
+            1,
+            { parserOptions: { sourceType: "module" } }
+        ),
+        invalid(
+            "export default ((a, b) => a + b)",
+            "export default (a, b) => a + b",
+            "ArrowFunctionExpression",
+            1,
+            { parserOptions: { sourceType: "module" } }
+        ),
+        invalid(
+            "export default (a => a)",
+            "export default a => a",
+            "ArrowFunctionExpression",
+            1,
+            { parserOptions: { sourceType: "module" } }
+        ),
+        invalid(
+            "export default (a = b)",
+            "export default a = b",
+            "AssignmentExpression",
+            1,
+            { parserOptions: { sourceType: "module" } }
+        ),
+        invalid(
+            "export default (a ? b : c)",
+            "export default a ? b : c",
+            "ConditionalExpression",
+            1,
+            { parserOptions: { sourceType: "module" } }
+        ),
+        invalid(
+            "export default (a)",
+            "export default a",
+            "Identifier",
+            1,
+            { parserOptions: { sourceType: "module" } }
+        ),
         invalid(
             "for (foo of(bar));",
             "for (foo of bar);",