Fix: camelcase ignoreGlobals shouldn't apply to undef vars (refs #14857…

…) (#14966)
eslint · Aug 24, 2021 · 3409785 · 3409785
1 parent b301069
commit 3409785
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 18 deletions.
diff --git a/lib/rules/camelcase.js b/lib/rules/camelcase.js
@@ -240,27 +240,26 @@ module.exports = {
 
             // Report camelcase of global variable references ------------------
             Program() {
-                if (ignoreGlobals) {
-                    return;
-                }
-
                 const scope = context.getScope();
 
-                // Defined globals in config files or directive comments.
-                for (const variable of scope.variables) {
-                    if (
-                        variable.identifiers.length > 0 ||
-                        isGoodName(variable.name)
-                    ) {
-                        continue;
-                    }
-                    for (const reference of variable.references) {
+                if (!ignoreGlobals) {
 
-                        /*
-                         * For backward compatibility, this rule reports read-only
-                         * references as well.
-                         */
-                        reportReferenceId(reference.identifier);
+                    // Defined globals in config files or directive comments.
+                    for (const variable of scope.variables) {
+                        if (
+                            variable.identifiers.length > 0 ||
+                            isGoodName(variable.name)
+                        ) {
+                            continue;
+                        }
+                        for (const reference of variable.references) {
+
+                            /*
+                             * For backward compatibility, this rule reports read-only
+                             * references as well.
+                             */
+                            reportReferenceId(reference.identifier);
+                        }
                     }
                 }
 

diff --git a/tests/lib/rules/camelcase.js b/tests/lib/rules/camelcase.js
@@ -1011,6 +1011,28 @@ ruleTester.run("camelcase", rule, {
                 }
             ]
         },
+        {
+            code: "undefined_variable;",
+            options: [{ ignoreGlobals: true }],
+            errors: [
+                {
+                    messageId: "notCamelCase",
+                    data: { name: "undefined_variable" },
+                    type: "Identifier"
+                }
+            ]
+        },
+        {
+            code: "implicit_global = 1;",
+            options: [{ ignoreGlobals: true }],
+            errors: [
+                {
+                    messageId: "notCamelCase",
+                    data: { name: "implicit_global" },
+                    type: "Identifier"
+                }
+            ]
+        },
         {
             code: "export * as snake_cased from 'mod'",
             parserOptions: { ecmaVersion: 2020, sourceType: "module" },