From 420a983e89c5eea6d7c82a9a982564acb1ac9591 Mon Sep 17 00:00:00 2001 From: Kai Cataldo Date: Sat, 4 Apr 2020 00:13:46 -0400 Subject: [PATCH] Upgrade: levn@0.4.1 (fixes #9366) --- package.json | 2 +- tests/lib/linter/linter.js | 21 +++++++++++++++++++-- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index ed15f61d02b..496f6a48b73 100644 --- a/package.json +++ b/package.json @@ -69,7 +69,7 @@ "is-glob": "^4.0.0", "js-yaml": "^3.13.1", "json-stable-stringify-without-jsonify": "^1.0.1", - "levn": "^0.3.0", + "levn": "^0.4.1", "lodash": "^4.17.14", "minimatch": "^3.0.4", "natural-compare": "^1.4.0", diff --git a/tests/lib/linter/linter.js b/tests/lib/linter/linter.js index 74d231ed1ff..4a1482def0c 100644 --- a/tests/lib/linter/linter.js +++ b/tests/lib/linter/linter.js @@ -2733,14 +2733,31 @@ describe("Linter", () => { }); describe("when evaluating code with comments which have colon in its value", () => { - const code = "/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: \"data:image\\/|\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-\"}] */\nalert('test');"; + const code = "/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: \"data:image\\/|\\\\s*require\\\\s*\\\\(|^\\\\s*loader\\\\.lazy|-\\\\*-\"}] */\nalert('test');"; it("should not parse errors, should report a violation", () => { const messages = linter.verify(code, {}, filename); assert.strictEqual(messages.length, 1); assert.strictEqual(messages[0].ruleId, "max-len"); - assert.strictEqual(messages[0].message, "This line has a length of 122. Maximum allowed is 100."); + assert.strictEqual(messages[0].message, "This line has a length of 128. Maximum allowed is 100."); + assert.include(messages[0].nodeType, "Program"); + }); + }); + + describe("when evaluating code with comments that contain escape sequences", () => { + const code = '/* eslint max-len: ["error", 1, { ignoreComments: true, ignorePattern: "console\\.log\\\\(" }] */\nconsole.log("test");\nvar a = "test2";'; + + it("should validate correctly", () => { + const config = { rules: {} }; + + const messages = linter.verify(code, config, filename); + + assert.strictEqual(messages.length, 1); + assert.strictEqual(messages[0].ruleId, "max-len"); + assert.strictEqual(messages[0].message, "This line has a length of 16. Maximum allowed is 1."); + assert.strictEqual(messages[0].line, 3); + assert.strictEqual(messages[0].column, 1); assert.include(messages[0].nodeType, "Program"); }); });