From 56f6b901e53314fbaf8ea55fa39d6c9eca4e85df Mon Sep 17 00:00:00 2001 From: Minh Nguyen Date: Fri, 22 May 2020 02:22:25 +0100 Subject: [PATCH] Update: Drop @typescript-eslint/eslint-recommended from `eslint --init` `@typescript-eslint/recommended` now extends from `@typescript-eslint/eslint-recommended`: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0 --- lib/init/config-initializer.js | 1 - tests/lib/init/config-initializer.js | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js index 00f17678fc6..c86f6784d31 100644 --- a/lib/init/config-initializer.js +++ b/lib/init/config-initializer.js @@ -325,7 +325,6 @@ function processAnswers(answers) { } } if (answers.typescript && config.extends.includes("eslint:recommended")) { - config.extends.push("plugin:@typescript-eslint/eslint-recommended"); config.extends.push("plugin:@typescript-eslint/recommended"); } diff --git a/tests/lib/init/config-initializer.js b/tests/lib/init/config-initializer.js index fe9120f7de1..06934955feb 100644 --- a/tests/lib/init/config-initializer.js +++ b/tests/lib/init/config-initializer.js @@ -176,7 +176,7 @@ describe("configInitializer", () => { assert.strictEqual(config.parser, "@typescript-eslint/parser"); assert.deepStrictEqual(config.plugins, ["@typescript-eslint"]); - assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]); + assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/recommended"]); }); it("should enable typescript parser and plugin with vue", () => { @@ -184,7 +184,7 @@ describe("configInitializer", () => { answers.typescript = true; const config = init.processAnswers(answers); - assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]); + assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential", "plugin:@typescript-eslint/recommended"]); assert.strictEqual(config.parserOptions.parser, "@typescript-eslint/parser"); assert.deepStrictEqual(config.plugins, ["vue", "@typescript-eslint"]); });