Fix: no-extra-label autofix removes comments (#12298)

eslint · Sep 29, 2019 · 6ad7e86 · 6ad7e86
1 parent acec201
commit 6ad7e86
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 1 deletion.
diff --git a/lib/rules/no-extra-label.js b/lib/rules/no-extra-label.js
@@ -116,7 +116,15 @@ module.exports = {
                             node: labelNode,
                             messageId: "unexpected",
                             data: labelNode,
-                            fix: fixer => fixer.removeRange([sourceCode.getFirstToken(node).range[1], labelNode.range[1]])
+                            fix(fixer) {
+                                const breakOrContinueToken = sourceCode.getFirstToken(node);
+
+                                if (sourceCode.commentsExistBetween(breakOrContinueToken, labelNode)) {
+                                    return null;
+                                }
+
+                                return fixer.removeRange([breakOrContinueToken.range[1], labelNode.range[1]]);
+                            }
                         });
                     }
                     return;

diff --git a/tests/lib/rules/no-extra-label.js b/tests/lib/rules/no-extra-label.js
@@ -106,6 +106,48 @@ ruleTester.run("no-extra-label", rule, {
                 }
             `,
             errors: [{ messageId: "unexpected", data: { name: "A" }, type: "Identifier", line: 2 }]
+        },
+
+        // Should not autofix if it would remove comments
+        {
+            code: "A: while(true) { /*comment*/break A; }",
+            output: "A: while(true) { /*comment*/break; }",
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
+        },
+        {
+            code: "A: while(true) { break/**/ A; }",
+            output: null,
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
+        },
+        {
+            code: "A: while(true) { continue /**/ A; }",
+            output: null,
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
+        },
+        {
+            code: "A: while(true) { break /**/A; }",
+            output: null,
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
+        },
+        {
+            code: "A: while(true) { continue/**/A; }",
+            output: null,
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
+        },
+        {
+            code: "A: while(true) { continue A/*comment*/; }",
+            output: "A: while(true) { continue/*comment*/; }",
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
+        },
+        {
+            code: "A: while(true) { break A//comment\n }",
+            output: "A: while(true) { break//comment\n }",
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
+        },
+        {
+            code: "A: while(true) { break A/*comment*/\nfoo() }",
+            output: "A: while(true) { break/*comment*/\nfoo() }",
+            errors: [{ messageId: "unexpected", data: { name: "A" } }]
         }
     ]
 });