From 6cfbd03b3f22edb4d1c9c61c64eea7c129da71aa Mon Sep 17 00:00:00 2001 From: Minh Nguyen Date: Fri, 12 Jun 2020 00:14:28 +0100 Subject: [PATCH] Update: Drop @typescript-eslint/eslint-recommended from `eslint --init` (#13340) `@typescript-eslint/recommended` now extends from `@typescript-eslint/eslint-recommended`: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0 --- lib/init/config-initializer.js | 1 - tests/lib/init/config-initializer.js | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js index eb8c7557431..e14f1cb0824 100644 --- a/lib/init/config-initializer.js +++ b/lib/init/config-initializer.js @@ -321,7 +321,6 @@ function processAnswers(answers) { } } if (answers.typescript && config.extends.includes("eslint:recommended")) { - config.extends.push("plugin:@typescript-eslint/eslint-recommended"); config.extends.push("plugin:@typescript-eslint/recommended"); } diff --git a/tests/lib/init/config-initializer.js b/tests/lib/init/config-initializer.js index 945e1854fba..12fe18aa2c3 100644 --- a/tests/lib/init/config-initializer.js +++ b/tests/lib/init/config-initializer.js @@ -174,7 +174,7 @@ describe("configInitializer", () => { assert.strictEqual(config.parser, "@typescript-eslint/parser"); assert.deepStrictEqual(config.plugins, ["@typescript-eslint"]); - assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]); + assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/recommended"]); }); it("should enable typescript parser and plugin with vue", () => { @@ -182,7 +182,7 @@ describe("configInitializer", () => { answers.typescript = true; const config = init.processAnswers(answers); - assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]); + assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential", "plugin:@typescript-eslint/recommended"]); assert.strictEqual(config.parserOptions.parser, "@typescript-eslint/parser"); assert.deepStrictEqual(config.plugins, ["vue", "@typescript-eslint"]); });