Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Update: added typescript-eslint/recommended configs for init (#13235)
  • Loading branch information
anikethsaha committed May 14, 2020
1 parent 3d03df0 commit 742941d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/init/config-initializer.js
Expand Up @@ -326,6 +326,7 @@ function processAnswers(answers) {
}
if (answers.typescript && config.extends.includes("eslint:recommended")) {
config.extends.push("plugin:@typescript-eslint/eslint-recommended");
config.extends.push("plugin:@typescript-eslint/recommended");
}

// normalize extends
Expand Down
3 changes: 2 additions & 1 deletion tests/lib/init/config-initializer.js
Expand Up @@ -176,14 +176,15 @@ describe("configInitializer", () => {

assert.strictEqual(config.parser, "@typescript-eslint/parser");
assert.deepStrictEqual(config.plugins, ["@typescript-eslint"]);
assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended"]);
assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]);
});

it("should enable typescript parser and plugin with vue", () => {
answers.framework = "vue";
answers.typescript = true;
const config = init.processAnswers(answers);

assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]);
assert.strictEqual(config.parserOptions.parser, "@typescript-eslint/parser");
assert.deepStrictEqual(config.plugins, ["vue", "@typescript-eslint"]);
});
Expand Down

0 comments on commit 742941d

Please sign in to comment.