From 7686d7feaccc7b8fee927eda6602d641d8de1e5c Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Sat, 13 Jun 2020 02:35:09 +0200 Subject: [PATCH] Update: semi-spacing should check do-while statements (#13358) --- lib/rules/semi-spacing.js | 1 + tests/lib/rules/semi-spacing.js | 49 ++++++++++++++++++++++++++++++++- 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/lib/rules/semi-spacing.js b/lib/rules/semi-spacing.js index 936e7661ef4..5c546f29028 100644 --- a/lib/rules/semi-spacing.js +++ b/lib/rules/semi-spacing.js @@ -223,6 +223,7 @@ module.exports = { BreakStatement: checkNode, ContinueStatement: checkNode, DebuggerStatement: checkNode, + DoWhileStatement: checkNode, ReturnStatement: checkNode, ThrowStatement: checkNode, ImportDeclaration: checkNode, diff --git a/tests/lib/rules/semi-spacing.js b/tests/lib/rules/semi-spacing.js index 6582a5ca690..b01dac04b15 100644 --- a/tests/lib/rules/semi-spacing.js +++ b/tests/lib/rules/semi-spacing.js @@ -55,7 +55,9 @@ ruleTester.run("semi-spacing", rule, { "function foo(){return 2;}", "for(var i = 0; i < results.length;) {}", { code: "function foo() { return 2; }", options: [{ after: false }] }, - { code: "for ( var i = 0;i < results.length; ) {}", options: [{ after: false }] } + { code: "for ( var i = 0;i < results.length; ) {}", options: [{ after: false }] }, + + "do {} while (true); foo" ], invalid: [ { @@ -370,6 +372,51 @@ ruleTester.run("semi-spacing", rule, { endColumn: 7 } ] + }, + { + code: "do {} while (true) ;", + output: "do {} while (true);", + errors: [{ + messageId: "unexpectedWhitespaceBefore", + type: "DoWhileStatement", + line: 1, + column: 19, + endLine: 1, + endColumn: 20 + }] + }, + { + code: "do {} while (true);foo", + output: "do {} while (true); foo", + errors: [{ + messageId: "missingWhitespaceAfter", + type: "DoWhileStatement", + line: 1, + column: 19, + endLine: 1, + endColumn: 20 + }] + }, + { + code: "do {} while (true); foo", + output: "do {} while (true) ;foo", + options: [{ before: true, after: false }], + errors: [{ + messageId: "missingWhitespaceBefore", + type: "DoWhileStatement", + line: 1, + column: 19, + endLine: 1, + endColumn: 20 + }, + { + messageId: "unexpectedWhitespaceAfter", + type: "DoWhileStatement", + line: 1, + column: 20, + endLine: 1, + endColumn: 22 + }] } ] });