Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Update: improve report location for space-infix-ops (#12324)
  • Loading branch information
golopot authored and kaicataldo committed Nov 1, 2019
1 parent 94ff921 commit 7e41355
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 14 deletions.
2 changes: 1 addition & 1 deletion lib/rules/space-infix-ops.js
Expand Up @@ -69,7 +69,7 @@ module.exports = {
function report(mainNode, culpritToken) {
context.report({
node: mainNode,
loc: culpritToken.loc.start,
loc: culpritToken.loc,
message: "Operator '{{operator}}' must be spaced.",
data: {
operator: culpritToken.value
Expand Down
39 changes: 26 additions & 13 deletions tests/lib/rules/space-infix-ops.js
Expand Up @@ -57,7 +57,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
column: 2,
endColumn: 3
}]
},
{
Expand All @@ -67,7 +68,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 3
column: 3,
endColumn: 4
}]
},
{
Expand All @@ -77,7 +79,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
column: 2,
endColumn: 3
}]
},
{
Expand All @@ -87,7 +90,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 2
column: 2,
endColumn: 4
}]
},
{
Expand All @@ -97,7 +101,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 3
column: 3,
endColumn: 5
}]
},
{
Expand All @@ -107,7 +112,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 2
column: 2,
endColumn: 4
}]
},
{
Expand Down Expand Up @@ -147,7 +153,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
column: 2,
endColumn: 3
}]
},
{
Expand All @@ -157,7 +164,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
column: 2,
endColumn: 3
}]
},
{
Expand All @@ -167,7 +175,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 6
column: 6,
endColumn: 7
}]
},
{
Expand All @@ -177,7 +186,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
column: 2,
endColumn: 3
}]
},
{
Expand All @@ -187,7 +197,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 3
column: 3,
endColumn: 4
}]
},
{
Expand All @@ -197,7 +208,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 6
column: 6,
endColumn: 7
}]
},
{
Expand All @@ -207,7 +219,8 @@ ruleTester.run("space-infix-ops", rule, {
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 7
column: 7,
endColumn: 8
}]
},
{
Expand Down

0 comments on commit 7e41355

Please sign in to comment.