Skip to content

Commit 95e1c70

Browse files
author
Kai Cataldo
authoredApr 7, 2020
Upgrade: levn@0.4.1 (fixes #9366) (#13140)
* Upgrade: levn@0.4.1 (fixes #9366) * Use String.raw to improve readability of tests * Address feedback * Update optionator@0.9.1
1 parent c41de38 commit 95e1c70

File tree

2 files changed

+34
-4
lines changed

2 files changed

+34
-4
lines changed
 

‎package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@
6969
"is-glob": "^4.0.0",
7070
"js-yaml": "^3.13.1",
7171
"json-stable-stringify-without-jsonify": "^1.0.1",
72-
"levn": "^0.3.0",
72+
"levn": "^0.4.1",
7373
"lodash": "^4.17.14",
7474
"minimatch": "^3.0.4",
7575
"natural-compare": "^1.4.0",
76-
"optionator": "^0.8.3",
76+
"optionator": "^0.9.1",
7777
"progress": "^2.0.0",
7878
"regexpp": "^3.0.0",
7979
"semver": "^7.1.1",

‎tests/lib/linter/linter.js

+32-2
Original file line numberDiff line numberDiff line change
@@ -2733,18 +2733,48 @@ describe("Linter", () => {
27332733
});
27342734

27352735
describe("when evaluating code with comments which have colon in its value", () => {
2736-
const code = "/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: \"data:image\\/|\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-\"}] */\nalert('test');";
2736+
const code = String.raw`
2737+
/* eslint max-len: [2, 100, 2, {ignoreUrls: true, ignorePattern: "data:image\\/|\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-"}] */
2738+
alert('test');
2739+
`;
27372740

27382741
it("should not parse errors, should report a violation", () => {
27392742
const messages = linter.verify(code, {}, filename);
27402743

27412744
assert.strictEqual(messages.length, 1);
27422745
assert.strictEqual(messages[0].ruleId, "max-len");
2743-
assert.strictEqual(messages[0].message, "This line has a length of 122. Maximum allowed is 100.");
2746+
assert.strictEqual(messages[0].message, "This line has a length of 129. Maximum allowed is 100.");
27442747
assert.include(messages[0].nodeType, "Program");
27452748
});
27462749
});
27472750

2751+
describe("when evaluating code with comments that contain escape sequences", () => {
2752+
const code = String.raw`
2753+
/* eslint max-len: ["error", 1, { ignoreComments: true, ignorePattern: "console\\.log\\(" }] */
2754+
console.log("test");
2755+
consolexlog("test2");
2756+
var a = "test2";
2757+
`;
2758+
2759+
it("should validate correctly", () => {
2760+
const config = { rules: {} };
2761+
const messages = linter.verify(code, config, filename);
2762+
const [message1, message2] = messages;
2763+
2764+
assert.strictEqual(messages.length, 2);
2765+
assert.strictEqual(message1.ruleId, "max-len");
2766+
assert.strictEqual(message1.message, "This line has a length of 21. Maximum allowed is 1.");
2767+
assert.strictEqual(message1.line, 4);
2768+
assert.strictEqual(message1.column, 1);
2769+
assert.include(message1.nodeType, "Program");
2770+
assert.strictEqual(message2.ruleId, "max-len");
2771+
assert.strictEqual(message2.message, "This line has a length of 16. Maximum allowed is 1.");
2772+
assert.strictEqual(message2.line, 5);
2773+
assert.strictEqual(message2.column, 1);
2774+
assert.include(message2.nodeType, "Program");
2775+
});
2776+
});
2777+
27482778
describe("when evaluating a file with a shebang", () => {
27492779
const code = "#!bin/program\n\nvar foo;;";
27502780

0 commit comments

Comments
 (0)
Please sign in to comment.