Skip to content

Commit

Permalink
Update: space-infix-ops reports violating operator (#10934)
Browse files Browse the repository at this point in the history
  • Loading branch information
@madbence @not-an-aardvark
madbence authored and not-an-aardvark committed Dec 8, 2018
1 parent c14f717 commit 9666aba
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 34 deletions.
5 changes: 4 additions & 1 deletion lib/rules/space-infix-ops.js
View file
Expand Up @@ -69,7 +69,10 @@ module.exports = {
context.report({
node: mainNode,
loc: culpritToken.loc.start,
message: "Infix operators must be spaced.",
message: "Operator '{{operator}}' must be spaced.",
data: {
operator: culpritToken.value
},
fix(fixer) {
const previousToken = sourceCode.getTokenBefore(culpritToken);
const afterToken = sourceCode.getTokenAfter(culpritToken);
Expand Down
66 changes: 33 additions & 33 deletions tests/lib/rules/space-infix-ops.js
View file
Expand Up @@ -54,7 +54,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a+b",
output: "a + b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
Expand All @@ -64,7 +64,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a +b",
output: "a + b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 3
Expand All @@ -74,7 +74,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a+ b",
output: "a + b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '+' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
Expand All @@ -84,7 +84,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a||b",
output: "a || b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 2
Expand All @@ -94,7 +94,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ||b",
output: "a || b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 3
Expand All @@ -104,7 +104,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a|| b",
output: "a || b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 2
Expand All @@ -114,7 +114,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a=b",
output: "a = b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "AssignmentExpression",
line: 1,
column: 2
Expand All @@ -124,7 +124,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a= b",
output: "a = b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "AssignmentExpression",
line: 1,
column: 2
Expand All @@ -134,7 +134,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a =b",
output: "a = b",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "AssignmentExpression",
line: 1,
column: 3
Expand All @@ -144,7 +144,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a?b:c",
output: "a ? b:c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
Expand All @@ -154,7 +154,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a?b : c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
Expand All @@ -164,7 +164,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ? b:c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 6
Expand All @@ -174,7 +174,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a? b : c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 2
Expand All @@ -184,7 +184,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ?b : c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '?' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 3
Expand All @@ -194,7 +194,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ? b: c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 6
Expand All @@ -204,7 +204,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "a ? b :c",
output: "a ? b : c",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator ':' must be spaced.",
type: "ConditionalExpression",
line: 1,
column: 7
Expand All @@ -214,7 +214,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a=b;",
output: "var a = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 6
Expand All @@ -224,7 +224,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a= b;",
output: "var a = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 6
Expand All @@ -234,7 +234,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a =b;",
output: "var a = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 7
Expand All @@ -244,7 +244,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a = b, c=d;",
output: "var a = b, c = d;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 13
Expand All @@ -257,7 +257,7 @@ ruleTester.run("space-infix-ops", rule, {
int32Hint: true
}],
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '|' must be spaced.",
type: "BinaryExpression",
line: 1,
column: 2
Expand All @@ -267,7 +267,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var output = test || (test && test.value) ||(test2 && test2.value);",
output: "var output = test || (test && test.value) || (test2 && test2.value);",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 43
Expand All @@ -277,7 +277,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var output = a ||(b && c.value) || (d && e.value);",
output: "var output = a || (b && c.value) || (d && e.value);",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 16
Expand All @@ -287,7 +287,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var output = a|| (b && c.value) || (d && e.value);",
output: "var output = a || (b && c.value) || (d && e.value);",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '||' must be spaced.",
type: "LogicalExpression",
line: 1,
column: 15
Expand All @@ -298,7 +298,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "const my_object = {key: 'value'}",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 16
Expand All @@ -309,12 +309,12 @@ ruleTester.run("space-infix-ops", rule, {
output: "var {a = 0} = bar;",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 7,
nodeType: "AssignmentPattern"
}, {
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 10,
nodeType: "VariableDeclarator"
Expand All @@ -325,7 +325,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "function foo(a = 0) { }",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 15,
nodeType: "AssignmentPattern"
Expand All @@ -336,7 +336,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "a ** b",
parserOptions: { ecmaVersion: 7 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '**' must be spaced.",
line: 1,
column: 2,
nodeType: "BinaryExpression"
Expand All @@ -346,7 +346,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "'foo'in{}",
output: "'foo' in {}",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator 'in' must be spaced.",
line: 1,
column: 6,
nodeType: "BinaryExpression"
Expand All @@ -356,7 +356,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "'foo'instanceof{}",
output: "'foo' instanceof {}",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator 'instanceof' must be spaced.",
line: 1,
column: 6,
nodeType: "BinaryExpression"
Expand All @@ -369,7 +369,7 @@ ruleTester.run("space-infix-ops", rule, {
code: "var a: Foo= b;",
output: "var a: Foo = b;",
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
type: "VariableDeclarator",
line: 1,
column: 11
Expand All @@ -381,7 +381,7 @@ ruleTester.run("space-infix-ops", rule, {
output: "function foo(a: number = 0): Foo { }",
parserOptions: { ecmaVersion: 6 },
errors: [{
message: "Infix operators must be spaced.",
message: "Operator '=' must be spaced.",
line: 1,
column: 23,
nodeType: "AssignmentPattern"
Expand Down

0 comments on commit 9666aba

Please sign in to comment.