From 988d8428811934943ce13b2d8b833d795ac2bb4a Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Wed, 1 Apr 2020 17:39:09 +0200 Subject: [PATCH] Fix: add end location to report in no-useless-concat (refs #12334) (#13110) --- lib/rules/no-useless-concat.js | 2 +- tests/lib/rules/no-useless-concat.js | 28 +++++++++++++++++++++++++--- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/lib/rules/no-useless-concat.js b/lib/rules/no-useless-concat.js index aa46742abdd..cfc60c8fb51 100644 --- a/lib/rules/no-useless-concat.js +++ b/lib/rules/no-useless-concat.js @@ -105,7 +105,7 @@ module.exports = { context.report({ node, - loc: operatorToken.loc.start, + loc: operatorToken.loc, messageId: "unexpectedConcat" }); } diff --git a/tests/lib/rules/no-useless-concat.js b/tests/lib/rules/no-useless-concat.js index 9376266623b..c15b88f1817 100644 --- a/tests/lib/rules/no-useless-concat.js +++ b/tests/lib/rules/no-useless-concat.js @@ -42,7 +42,25 @@ ruleTester.run("no-useless-concat", rule, { { code: "'a' + 'b'", errors: [ - { messageId: "unexpectedConcat" } + { + messageId: "unexpectedConcat", + line: 1, + column: 5, + endLine: 1, + endColumn: 6 + } + ] + }, + { + code: "'a' +\n'b' + 'c'", + errors: [ + { + messageId: "unexpectedConcat", + line: 2, + column: 5, + endLine: 2, + endColumn: 6 + } ] }, { @@ -57,12 +75,16 @@ ruleTester.run("no-useless-concat", rule, { { messageId: "unexpectedConcat", line: 1, - column: 5 + column: 5, + endLine: 1, + endColumn: 6 }, { messageId: "unexpectedConcat", line: 1, - column: 11 + column: 11, + endLine: 1, + endColumn: 12 } ] },