Fix: prefer-destructuring false positive on "super" (fixes #9625) (#9626

)
eslint · Nov 19, 2017 · a015234 · a015234
1 parent 0cf081e
commit a015234
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/rules/prefer-destructuring.js b/lib/rules/prefer-destructuring.js
@@ -145,7 +145,7 @@ module.exports = {
          * @returns {void}
          */
         function performCheck(leftNode, rightNode, reportNode) {
-            if (rightNode.type !== "MemberExpression") {
+            if (rightNode.type !== "MemberExpression" || rightNode.object.type === "Super") {
                 return;
             }
 

diff --git a/tests/lib/rules/prefer-destructuring.js b/tests/lib/rules/prefer-destructuring.js
@@ -130,7 +130,8 @@ ruleTester.run("prefer-destructuring", rule, {
         {
             code: "var foo = object.foo;",
             options: [{ VariableDeclarator: { object: false }, AssignmentExpression: { object: true } }]
-        }
+        },
+        "class Foo extends Bar { static foo() {var foo = super.foo} }"
     ],
 
     invalid: [
@@ -276,6 +277,13 @@ ruleTester.run("prefer-destructuring", rule, {
                 message: "Use object destructuring.",
                 type: "AssignmentExpression"
             }]
+        },
+        {
+            code: "class Foo extends Bar { static foo() {var bar = super.foo.bar} }",
+            errors: [{
+                message: "Use object destructuring.",
+                type: "VariableDeclarator"
+            }]
         }
     ]
 });