Update: fix no-extra-parens CallExpression#callee false negatives (#1…

…2743)
eslint · Jan 9, 2020 · b2c6209 · b2c6209
1 parent 14b42c3
commit b2c6209
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/rules/no-extra-parens.js b/lib/rules/no-extra-parens.js
@@ -418,11 +418,10 @@ module.exports = {
                     hasDoubleExcessParens(callee) ||
                     !isIIFE(node) && !hasNewParensException && !(
 
-                        /*
-                         * Allow extra parens around a new expression if
-                         * there are intervening parentheses.
-                         */
-                        (callee.type === "MemberExpression" && doesMemberExpressionContainCallExpression(callee))
+                        // Allow extra parens around a new expression if they are intervening parentheses.
+                        node.type === "NewExpression" &&
+                        callee.type === "MemberExpression" &&
+                        doesMemberExpressionContainCallExpression(callee)
                     )
                 ) {
                     report(node.callee);

diff --git a/tests/lib/rules/no-extra-parens.js b/tests/lib/rules/no-extra-parens.js
@@ -673,6 +673,12 @@ ruleTester.run("no-extra-parens", rule, {
         invalid("(new foo.bar()).baz", "new foo.bar().baz", "NewExpression"),
         invalid("(new foo.bar()).baz()", "new foo.bar().baz()", "NewExpression"),
 
+        invalid("(a)()", "a()", "Identifier"),
+        invalid("(a.b)()", "a.b()", "MemberExpression"),
+        invalid("(a())()", "a()()", "CallExpression"),
+        invalid("(a.b())()", "a.b()()", "CallExpression"),
+        invalid("(a().b)()", "a().b()", "MemberExpression"),
+        invalid("(a().b.c)()", "a().b.c()", "MemberExpression"),
         invalid("new (A)", "new A", "Identifier"),
         invalid("(new A())()", "new A()()", "NewExpression"),
         invalid("(new A(1))()", "new A(1)()", "NewExpression"),