From bd117a40e875e1fec0247e0a1d0ded350420c9d3 Mon Sep 17 00:00:00 2001 From: ark120202 Date: Wed, 30 Oct 2019 17:00:46 +0000 Subject: [PATCH] Address review comments --- docs/rules/no-useless-computed-key.md | 4 ++-- lib/rules/no-useless-computed-key.js | 2 +- tests/lib/rules/no-useless-computed-key.js | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/rules/no-useless-computed-key.md b/docs/rules/no-useless-computed-key.md index cde504c47b2..9b3c592849b 100644 --- a/docs/rules/no-useless-computed-key.md +++ b/docs/rules/no-useless-computed-key.md @@ -1,4 +1,4 @@ -# Disallow unnecessary computed property keys (no-useless-computed-key) +# Disallow unnecessary computed property keys in objects and classes (no-useless-computed-key) It's unnecessary to use computed properties with literals such as: @@ -64,7 +64,7 @@ class Foo { [0]() {} ['a']() {} get ['b']() {} - set ['c']() {} + set ['c'](value) {} static ['a']() {} } diff --git a/lib/rules/no-useless-computed-key.js b/lib/rules/no-useless-computed-key.js index 1c54be196df..b5e53174e42 100644 --- a/lib/rules/no-useless-computed-key.js +++ b/lib/rules/no-useless-computed-key.js @@ -22,7 +22,7 @@ module.exports = { type: "suggestion", docs: { - description: "disallow unnecessary computed property keys in object literals", + description: "disallow unnecessary computed property keys in objects and classes", category: "ECMAScript 6", recommended: false, url: "https://eslint.org/docs/rules/no-useless-computed-key" diff --git a/tests/lib/rules/no-useless-computed-key.js b/tests/lib/rules/no-useless-computed-key.js index f7cc851d3ee..cd33cc732ca 100644 --- a/tests/lib/rules/no-useless-computed-key.js +++ b/tests/lib/rules/no-useless-computed-key.js @@ -24,6 +24,7 @@ ruleTester.run("no-useless-computed-key", rule, { "({ [x]: 0 });", "({ a: 0, [b](){} })", "({ ['__proto__']: [] })", + { code: "class Foo { a() {} }", options: [{ enforceForClassMembers: true }] }, { code: "class Foo { 'a'() {} }", options: [{ enforceForClassMembers: true }] }, { code: "class Foo { [x]() {} }", options: [{ enforceForClassMembers: true }] }, { code: "class Foo { ['constructor']() {} }", options: [{ enforceForClassMembers: true }] },