From de0aab95005f172db72196fc3fd18e91ee9a5880 Mon Sep 17 00:00:00 2001 From: YeonJuan Date: Sat, 23 May 2020 08:36:31 +0900 Subject: [PATCH] Fix: report end loc in one-var-declaration-per-line (refs #12334) (#13326) --- lib/rules/one-var-declaration-per-line.js | 2 +- tests/lib/rules/one-var-declaration-per-line.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/rules/one-var-declaration-per-line.js b/lib/rules/one-var-declaration-per-line.js index 30ca2cf4983..db4674760a0 100644 --- a/lib/rules/one-var-declaration-per-line.js +++ b/lib/rules/one-var-declaration-per-line.js @@ -71,7 +71,7 @@ module.exports = { context.report({ node, messageId: "expectVarOnNewline", - loc: current.loc.start, + loc: current.loc, fix: fixer => fixer.insertTextBefore(current, "\n") }); } diff --git a/tests/lib/rules/one-var-declaration-per-line.js b/tests/lib/rules/one-var-declaration-per-line.js index 59af6205452..3103ef2d705 100644 --- a/tests/lib/rules/one-var-declaration-per-line.js +++ b/tests/lib/rules/one-var-declaration-per-line.js @@ -68,6 +68,7 @@ ruleTester.run("one-var-declaration-per-line", rule, { ], invalid: [ + { code: "var foo, bar;", output: "var foo, \nbar;", options: ["always"], errors: [{ line: 1, column: 10, endLine: 1, endColumn: 13 }] }, { code: "var a, b;", output: "var a, \nb;", options: ["always"], errors: [errorAt(1, 8)] }, { code: "let a, b;", output: "let a, \nb;", options: ["always"], parserOptions: { ecmaVersion: 6 }, errors: [errorAt(1, 8)] }, { code: "var a, b = 0;", output: "var a, \nb = 0;", options: ["always"], errors: [errorAt(1, 8)] }, @@ -76,6 +77,7 @@ ruleTester.run("one-var-declaration-per-line", rule, { { code: "let a, b = 0;", output: "let a, \nb = 0;", options: ["always"], parserOptions: { ecmaVersion: 6 }, errors: [errorAt(1, 8)] }, { code: "const a = 0, b = 0;", output: "const a = 0, \nb = 0;", options: ["always"], parserOptions: { ecmaVersion: 6 }, errors: [errorAt(1, 14)] }, + { code: "var foo, bar, baz = 0;", output: "var foo, bar, \nbaz = 0;", options: ["initializations"], errors: [{ line: 1, column: 15, endLine: 1, endColumn: 22 }] }, { code: "var a, b, c = 0;", output: "var a, b, \nc = 0;", options: ["initializations"], errors: [errorAt(1, 11)] }, { code: "var a, b,\nc = 0, d;", output: "var a, b,\nc = 0, \nd;", options: ["initializations"], errors: [errorAt(2, 8)] }, { code: "var a, b,\nc = 0, d = 0;", output: "var a, b,\nc = 0, \nd = 0;", options: ["initializations"], errors: [errorAt(2, 8)] },