From e13256e395cc413ce45a66c8562621d48440d8f4 Mon Sep 17 00:00:00 2001 From: Kai Cataldo Date: Wed, 22 Apr 2020 23:47:04 -0400 Subject: [PATCH] Chore: use espree.latestEcmaVersion in config-initializer (#13157) --- lib/init/config-initializer.js | 6 ++---- tests/lib/init/config-initializer.js | 7 ++++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js index 28dfad194a7..70f0a250ad1 100644 --- a/lib/init/config-initializer.js +++ b/lib/init/config-initializer.js @@ -15,6 +15,7 @@ const util = require("util"), inquirer = require("inquirer"), ProgressBar = require("progress"), semver = require("semver"), + espree = require("espree"), recConfig = require("../../conf/eslint-recommended"), ConfigOps = require("../shared/config-ops"), log = require("../shared/logging"), @@ -31,8 +32,6 @@ const debug = require("debug")("eslint:config-initializer"); // Private //------------------------------------------------------------------------------ -const DEFAULT_ECMA_VERSION = 2018; - /* istanbul ignore next: hard to test fs function */ /** * Create .eslintrc file in the current working directory @@ -265,8 +264,7 @@ function processAnswers(answers) { extends: [] }; - // set the latest ECMAScript version - config.parserOptions.ecmaVersion = DEFAULT_ECMA_VERSION; + config.parserOptions.ecmaVersion = espree.latestEcmaVersion; config.env.es6 = true; config.globals = { Atomics: "readonly", diff --git a/tests/lib/init/config-initializer.js b/tests/lib/init/config-initializer.js index 3393ae2befa..5f4690adfa8 100644 --- a/tests/lib/init/config-initializer.js +++ b/tests/lib/init/config-initializer.js @@ -15,6 +15,7 @@ const assert = require("chai").assert, os = require("os"), sinon = require("sinon"), sh = require("shelljs"), + espree = require("espree"), autoconfig = require("../../../lib/init/autoconfig"), npmUtils = require("../../../lib/init/npm-utils"); @@ -138,7 +139,7 @@ describe("configInitializer", () => { assert.strictEqual(config.env.es6, true); assert.strictEqual(config.globals.Atomics, "readonly"); assert.strictEqual(config.globals.SharedArrayBuffer, "readonly"); - assert.strictEqual(config.parserOptions.ecmaVersion, 2018); + assert.strictEqual(config.parserOptions.ecmaVersion, espree.latestEcmaVersion); assert.strictEqual(config.parserOptions.sourceType, "module"); assert.strictEqual(config.env.browser, true); assert.strictEqual(config.extends, "eslint:recommended"); @@ -156,7 +157,7 @@ describe("configInitializer", () => { const config = init.processAnswers(answers); assert.strictEqual(config.parserOptions.ecmaFeatures.jsx, true); - assert.strictEqual(config.parserOptions.ecmaVersion, 2018); + assert.strictEqual(config.parserOptions.ecmaVersion, espree.latestEcmaVersion); assert.deepStrictEqual(config.plugins, ["react"]); }); @@ -164,7 +165,7 @@ describe("configInitializer", () => { answers.framework = "vue"; const config = init.processAnswers(answers); - assert.strictEqual(config.parserOptions.ecmaVersion, 2018); + assert.strictEqual(config.parserOptions.ecmaVersion, espree.latestEcmaVersion); assert.deepStrictEqual(config.plugins, ["vue"]); assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential"]); });