Fix: Ignore import expressions in no-unused-expressions rule (#13387)

eslint · Jun 5, 2020 · e49732e · e49732e
1 parent 220349f
commit e49732e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/rules/no-unused-expressions.js b/lib/rules/no-unused-expressions.js
@@ -124,7 +124,7 @@ module.exports = {
                 return true;
             }
 
-            return /^(?:Assignment|Call|New|Update|Yield|Await)Expression$/u.test(node.type) ||
+            return /^(?:Assignment|Call|New|Update|Yield|Await|Import)Expression$/u.test(node.type) ||
                 (node.type === "UnaryExpression" && ["delete", "void"].indexOf(node.operator) >= 0);
         }
 

diff --git a/tests/lib/rules/no-unused-expressions.js b/tests/lib/rules/no-unused-expressions.js
@@ -70,6 +70,10 @@ ruleTester.run("no-unused-expressions", rule, {
             code: "shouldNotBeAffectedByAllowTemplateTagsOption()",
             options: [{ allowTaggedTemplates: true }],
             parserOptions: { ecmaVersion: 6 }
+        },
+        {
+            code: "import(\"foo\")",
+            parserOptions: { ecmaVersion: 11 }
         }
     ],
     invalid: [