From e49732eb41bff6347ca7718c3c5ca1d13f1cd2d3 Mon Sep 17 00:00:00 2001 From: Veniamin Krol <153412+vkrol@users.noreply.github.com> Date: Sat, 6 Jun 2020 02:05:06 +0300 Subject: [PATCH] Fix: Ignore import expressions in no-unused-expressions rule (#13387) --- lib/rules/no-unused-expressions.js | 2 +- tests/lib/rules/no-unused-expressions.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rules/no-unused-expressions.js b/lib/rules/no-unused-expressions.js index 26a25b7584b..8c049f556ff 100644 --- a/lib/rules/no-unused-expressions.js +++ b/lib/rules/no-unused-expressions.js @@ -124,7 +124,7 @@ module.exports = { return true; } - return /^(?:Assignment|Call|New|Update|Yield|Await)Expression$/u.test(node.type) || + return /^(?:Assignment|Call|New|Update|Yield|Await|Import)Expression$/u.test(node.type) || (node.type === "UnaryExpression" && ["delete", "void"].indexOf(node.operator) >= 0); } diff --git a/tests/lib/rules/no-unused-expressions.js b/tests/lib/rules/no-unused-expressions.js index 34051daa7b5..8ef2028c662 100644 --- a/tests/lib/rules/no-unused-expressions.js +++ b/tests/lib/rules/no-unused-expressions.js @@ -70,6 +70,10 @@ ruleTester.run("no-unused-expressions", rule, { code: "shouldNotBeAffectedByAllowTemplateTagsOption()", options: [{ allowTaggedTemplates: true }], parserOptions: { ecmaVersion: 6 } + }, + { + code: "import(\"foo\")", + parserOptions: { ecmaVersion: 11 } } ], invalid: [