Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
ci: add node v19 (#16443)
Node v19.0.0 has been released.
https://nodejs.org/en/blog/release/v19.0.0/

This PR adds the v19 matrix and fixes the following tests failure when using v19.0.0.

```console
% node -v
v19.0.0
% npx mocha tests/lib/shared/runtime-info.js
(snip)

1) RuntimeInfo
     environment()
       log and throw an error when checking for local ESLint version when returned output of command is malformed:

    AssertionError: expected [Function environment] to throw error including 'Unexpected token T in JSON at positio…' but got 'Unexpected token \'T\', "This is not …'
    + expected - actual

    -Unexpected token 'T', "This is not JSON" is not valid JSON
    +Unexpected token T in JSON at position 0

    at Context.<anonymous> (tests/lib/shared/runtime-info.js:209:20)
    at process.processImmediate (node:internal/timers:471:21)

2) RuntimeInfo
     environment()
       log and throw an error when checking for global ESLint version when returned output of command is malformed:

    AssertionError: expected [Function environment] to throw error including 'Unexpected token T in JSON at positio…' but got 'Unexpected token \'T\', "This is not …'
    + expected - actual

    -Unexpected token 'T', "This is not JSON" is not valid JSON
    +Unexpected token T in JSON at position 0

    at Context.<anonymous> (tests/lib/shared/runtime-info.js:217:20)
    at process.processImmediate (node:internal/timers:471:21)
```

This patch uses regexp to match both messages because the message has changed in v19.0.0.
  • Loading branch information
koic committed Oct 20, 2022
1 parent 740b208 commit e917a9a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [18.x, 17.x, 16.x, 14.x, 12.x, "12.22.0"]
node: [19.x, 18.x, 17.x, 16.x, 14.x, 12.x, "12.22.0"]
include:
- os: windows-latest
node: "16.x"
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/shared/runtime-info.js
Expand Up @@ -206,15 +206,15 @@ describe("RuntimeInfo", () => {
spawnSyncStubArgs[2] = "This is not JSON";
setupSpawnSyncStubReturnVals(spawnSyncStub, spawnSyncStubArgs);

assert.throws(RuntimeInfo.environment, "Unexpected token T in JSON at position 0");
assert.throws(RuntimeInfo.environment, /^Unexpected token .*T.* JSON/u);
assert.strictEqual(logErrorStub.args[0][0], "Error finding eslint version running the command `npm ls --depth=0 --json eslint`");
});

it("log and throw an error when checking for global ESLint version when returned output of command is malformed", () => {
spawnSyncStubArgs[4] = "This is not JSON";
setupSpawnSyncStubReturnVals(spawnSyncStub, spawnSyncStubArgs);

assert.throws(RuntimeInfo.environment, "Unexpected token T in JSON at position 0");
assert.throws(RuntimeInfo.environment, /^Unexpected token .*T.* JSON/u);
assert.strictEqual(logErrorStub.args[0][0], "Error finding eslint version running the command `npm ls --depth=0 --json eslint -g`");
});
});
Expand Down

0 comments on commit e917a9a

Please sign in to comment.