Skip to content

Commit

Permalink
Chore: upgrade eslint-plugin-eslint-plugin (#14738)
Browse files Browse the repository at this point in the history
  • Loading branch information
aladdin-add committed Jun 23, 2021
1 parent 1b8997a commit f113cdd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions lib/rules/dot-notation.js
Expand Up @@ -94,7 +94,7 @@ module.exports = {

// Don't perform any fixes if there are comments inside the brackets.
if (sourceCode.commentsExistBetween(leftBracket, rightBracket)) {
return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
return;
}

// Replace the brackets by an identifier.
Expand Down Expand Up @@ -154,12 +154,12 @@ module.exports = {

// A statement that starts with `let[` is parsed as a destructuring variable declaration, not a MemberExpression.
if (node.object.type === "Identifier" && node.object.name === "let" && !node.optional) {
return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
return;
}

// Don't perform any fixes if there are comments between the dot and the property name.
if (sourceCode.commentsExistBetween(dotToken, node.property)) {
return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
return;
}

// Replace the identifier to brackets.
Expand Down
8 changes: 4 additions & 4 deletions lib/rules/prefer-arrow-callback.js
Expand Up @@ -295,7 +295,7 @@ module.exports = {
* If the callback function has duplicates in its list of parameters (possible in sloppy mode),
* don't replace it with an arrow function, because this is a SyntaxError with arrow functions.
*/
return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
return;
}

// Remove `.bind(this)` if exists.
Expand All @@ -307,7 +307,7 @@ module.exports = {
* E.g. `(foo || function(){}).bind(this)`
*/
if (memberNode.type !== "MemberExpression") {
return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
return;
}

const callNode = memberNode.parent;
Expand All @@ -320,12 +320,12 @@ module.exports = {
* ^^^^^^^^^^^^
*/
if (astUtils.isParenthesised(sourceCode, memberNode)) {
return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
return;
}

// If comments exist in the `.bind(this)`, don't remove those.
if (sourceCode.commentsExistBetween(firstTokenToRemove, lastTokenToRemove)) {
return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
return;
}

yield fixer.removeRange([firstTokenToRemove.range[0], lastTokenToRemove.range[1]]);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -95,7 +95,7 @@
"ejs": "^3.0.2",
"eslint": "file:.",
"eslint-config-eslint": "file:packages/eslint-config-eslint",
"eslint-plugin-eslint-plugin": "^3.0.3",
"eslint-plugin-eslint-plugin": "^3.2.0",
"eslint-plugin-internal-rules": "file:tools/internal-rules",
"eslint-plugin-jsdoc": "^25.4.3",
"eslint-plugin-node": "^11.1.0",
Expand Down

0 comments on commit f113cdd

Please sign in to comment.