Multiple fixes not applying

[gioragutt]

I'm writing a rule that can possible apply two fixes on suggestion:

1. (always) add something to the opening element of a JSXElement
2. (optional) add an import statement at the beginning of the file

Here's my rule:

/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
    meta: {
        type: 'problem',
        docs: {
            description: 'ensures access to certain expressions is wrapped with hideSensitiveView',
            category: 'Best Practices',
            suggestion: true,
        },
        type: 'suggestion',
        fixable: 'code',
        messages: {
            missingHideSensitiveView: "Access to '{{ expression }}' in jsx does not have ref={hideSensitiveView}",
            addHideSensitiveViewInClosestElement:
                'Insert ref={hideSensitiveView} in the closest JSX Element (<{{ tag }}>...</{{ tag }}>)',
        },
    },
    create(context) {
        return {
            JSXExpressionContainer(/** @type {JSXExpressionContainerNode} */ node) {
                const propertyName = node.expression.property?.name;

                if (propertyName !== 'kidName' && propertyName !== 'possessiveName') {
                    return;
                }

                const closestJsxElement = validateNodeHasParentWithHideSensitiveViewRef(context, node);
                if (!closestJsxElement) {
                    return;
                }

                context.report({
                    node,
                    messageId: 'missingHideSensitiveView',
                    data: {
                        expression: context.getSourceCode().getText(node.expression),
                    },
                    suggest: [
                        {
                            messageId: 'addHideSensitiveViewInClosestElement',
                            data: {
                                tag: closestJsxElement.openingElement.name.name,
                            },
                            *fix(fixer) {
                                yield fixer.insertTextAfter(
                                    closestJsxElement.openingElement.name,
                                    ` ref={hideSensitiveView}`
                                );

                                if (shouldAddImport(node)) {
                                    yield fixer.insertTextBeforeRange(
                                        [0, 0],
                                        `import {hideSensitiveView} from '@repo/src/utils/uxcamHelper';\n`
                                    );
                                }
                            },
                        },
                    ],
                });
            },
        };
    },
};

My problem is that only one of the fixes is applied. If I remove the one that is applied, the other one would get applied.
I tried:

1. Returning Generator and Array
2. Switching the Yield/Push order

But that didn't help. Here are the output errors I get from the tests:

If I remove the import fix:

  actual: '\n' +
    'export default () => (\n' +
    '    <>\n' +
    '<View ref={hideSensitiveView}>{profileStore.kidName}</View>\n' +
    '<View ref={hideSensitiveView}>{profileStore.possessiveName}</View>\n' +
    '    </>\n' +
    ')',
  expected: "import {hideSensitiveView} from '@repo/src/utils/uxcamHelper';\n" +
    '\n' +
    'export default () => (\n' +
    '    <>\n' +
    '<View ref={hideSensitiveView}>{profileStore.kidName}</View>\n' +
    '<View ref={hideSensitiveView}>{profileStore.possessiveName}</View>\n' +
    '    </>\n' +
    ')',

And if I do nothing, or remove the text-adding fix:

  actual: "import {hideSensitiveView} from '@repo/src/utils/uxcamHelper';\n" +
    '\n' +
    'export default () => (\n' +
    '    <>\n' +
    '<View ref={hideSensitiveView}>{profileStore.kidName}</View>\n' +
    '<View>{profileStore.possessiveName}</View>\n' +
    '    </>\n' +
    ')',
  expected: "import {hideSensitiveView} from '@repo/src/utils/uxcamHelper';\n" +
    '\n' +
    'export default () => (\n' +
    '    <>\n' +
    '<View ref={hideSensitiveView}>{profileStore.kidName}</View>\n' +
    '<View ref={hideSensitiveView}>{profileStore.possessiveName}</View>\n' +
    '    </>\n' +
    ')',

[gioragutt]

I want to point out further, I run the plugin on my actual code, and it works fine. This means it may have something to do with the RuleRunner.

[mdjermanovic]

Hi @gioragutt!

Did you mean RuleTester? Can you share the test case that is failing?