Update: Improve no-extra-parens error message #10748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
|
👍 for plain English, thanks for contributing! We do need a CLA signature before we can merge. Let us know if you need help with that. Thanks! |
platinumazure
added
bug
|
I don't feel strongly about it, but how about the word "Unnecessary" instead of "Unexpected"? "Unexpected" sort of makes it sound like the rule is broken and isn't able to handle code with parentheses, when in fact it's working as expected by reporting the parentheses. |
When I encountered this error, it was not unclear to me what the
problem was or what alternative would be preferred.
The input was:
```js
return ( { foo: 1, bar: 2 }[ key ] || 0 );
```
Receiving the following in Atom's footer:
```
eslint (0|4), Gratuitous parentheses around expression., Line 165, Column 17
```
Using the phrase "Unnecessary" instead, which also matches the error
message used by other ESLint rules.
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I encountered this error, it was not unclear to me what the
problem was or what alternative would be preferred.
The input was:
Receiving the following in Atom's footer:
What is the purpose of this pull request? (put an "X" next to item)
[x] Changes an existing rule (template)