Fix: consistent-docs-url crashes if meta.docs isn't present

[s4san]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Issue ( #10722 )

What changes did you make? (Give an overview)

• Added a check to report missing property if metaDocs is null

Is there anything you'd like reviewers to focus on?

• Changed the checkMetaDocsUrl function

[platinumazure]

This change LGTM, thanks!

While we're in here, can we make sure there are tests for similar scenarios:

• Export value isn't an object
• Export value is an object with no meta property at all

If those are covered already, great!

[s4san]

@platinumazure I tried to cover those cases, but it seemed a bit out of scope for this PR. I will try to elaborate,

Case 1: meta property is not defined on the exports object.

This crashes eslint and curiously, the exportsNode is of type functionExpression. I did not get to explore this case further.

Case 2: meta property is defined with a value of undefined

This creates an exception in getPropertyFromObject method where it tries to access length of undefined.

I was hoping to create a separate issue for this but I couldn't get to it. Do you think these should be investigated separately or should they be addressed in this PR?

[platinumazure]

Creating a separate issue is fine. Thanks for checking!

[s4san]

I have created an issue #10750 and I would like to work on it

[platinumazure]

Since I realized I never mentioned it explicitly-- I'm waiting another day or so in case other team members want to take a look, before merging.

[platinumazure]

Merged-- thanks @s4san for contributing!