Chore: use meta.messages in some rules (1/4) #10764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
rule
mysticatea
reviewed
Aug 15, 2018
lib/rules/generator-star-spacing.js
Outdated
| const messageId = spaceRequired ? "missing" : "unexpected"; | ||
|
|
||
| // const message = "{{type}} space {{side}} *."; | ||
| const data = { side }; |
There was a problem hiding this comment.
I'd like to separate message IDs for before / after because languages other than English can't use the word as is.
aladdin-add
changed the title
platinumazure
approved these changes
Aug 17, 2018
| }, | ||
| schema: [], | ||
| messages: { | ||
| expectedMessages: "expected `meta.messages` property" |
There was a problem hiding this comment.
Nit: Could the first word be capitalized (Expected instead of expected)?
|
|
||
| create(context) { | ||
| return { | ||
| AssignmentExpression(node) { |
There was a problem hiding this comment.
Nit: This could be simplified using selectors: "AssignmentExpression[left.object.name='module'][left.property.name='exports']"(node) {
aladdin-add
changed the title
platinumazure
approved these changes
Aug 18, 2018
2 tasks
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
Not all the rules have to be changed in just one PR, I plan to separate it to 3~4 PR. temporally disabled the rule, and will enable it when all the changes finished.