New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint-recommended changes in eslint v6.0.0 #10768
Comments
I like all of the new candidates in the original post. I would like to remove the following from
I would like to reconsider the following:
|
I'd propose adding the following rules: If #11279 is accepted and implemented before the next major release, I would also propose adding that rule. I would lean against adding I'm ambivalent about adding Along those lines, I agree that we should remove |
agreed adding
furthermore, I'd love to propose:
|
In today's TSC meeting, the TSC decided to accept this change with specific rules to be decided on this issue. |
It seems like we need a full proposal to decide on. I'll propose the following: Add the following rules to
Remove the following rule:
|
I'm 👍 with everything except for |
Personally, I'm convinced that To me, this is a case where developers can either (a) use a terse notation that is occasionally subtlely wrong, or (b) use a more verbose notation that doesn't have those problems. So my opinion is that always doing (b) is an easy choice, and enforcing against the buggy choice is important for developers who might not be aware of the subtle bug. |
I'm 👍 to all, though I won't argue too hard for |
Adding this to the TSC agenda because we haven't reached a consensus on the issue. TSC Summary: We need to finalize a decision for which rules to add to TSC Question: What rules should be added? |
We've discussed in the 2019/04/11 TSC meeting. Resolution: We will modify eslint:recommended as follows:
And we will discuss no-prototype-builtins in the next TSC meeting on 4/25. (Goal is to have a final decision on that rule with that meeting.) |
In the last TSC meeting, the TSC decided to add |
Similar to previous release, new rules can be added to
eslint:recommended
(https://github.com/eslint/eslint#semantic-versioning-policy)some candidates:
require-unicode-regexp
no-misleading-character-class
no-async-promise-executor
require-atomic-updates
reconsider rules like
eval
,no-implied-eval
,no-new-func
. (The Function constructor is not recognized as eval or implied-eval #9406 (comment))no-console
no-mixed-spaces-and-tabs
: enable smart-tabs options.no-shadow-restricted-names
no-prototype-builtins
Rule proposal: Disallow number literals that lose precision #11279 (not accepted/implemented yet)
no-useless-catch
no-with
The text was updated successfully, but these errors were encountered: