Chore: use meta.messages in some rules (2/4) (refs #9870) #10773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
accepted
aladdin-add
changed the title
aladdin-add
changed the title
aladdin-add
force-pushed
the
chore/messages
branch
3 times, most recently
from
f8c5e02 to
e993ecb
Compare
|
Closing/reopening to see if the Appveyor build is fixed. (I think I temporarily broke it by enabling OAuth App access restrictions.) edit: It doesn't seem like it worked on this PR, which is strange because it definitely should have access now. Maybe it will work for new PRs. |
|
Trying again, it seems like Appveyor has two separate OAuth apps ("Appveyor" and "Appveyor CI"). edit: Seems like it worked this time 🎉 |
aladdin-add
force-pushed
the
chore/messages
branch
5 times, most recently
from
6e120be to
e974343
Compare
aladdin-add
removed
the
evaluating
aladdin-add
force-pushed
the
chore/messages
branch
2 times, most recently
from
fbd5867 to
33b849b
Compare
aladdin-add
force-pushed
the
chore/messages
branch
3 times, most recently
from
7cb8bca to
26e7392
Compare
|
Hi @aladdin-add, what are the next steps here? As an aside, would it be possible to edit the initial post to fill out the PR template? That way we can get some context when reviewing. 😄 Thanks! |
aladdin-add
force-pushed
the
chore/messages
branch
from
2ea2c0f to
9f123ed
Compare
aladdin-add
changed the title
aladdin-add
force-pushed
the
chore/messages
branch
from
9f123ed to
12f1314
Compare
Signed-off-by: weiran.zsd <weiran.zsd@alibaba-inc.com>
aladdin-add
force-pushed
the
chore/messages
branch
from
5780538 to
5cf6ece
Compare
|
I've updated and rebased, could you please take another look at the commit 5780538 ? 😄 |
not-an-aardvark
approved these changes
Jan 18, 2019
kaicataldo
approved these changes
Jan 18, 2019
|
Thanks for contributing to ESLint! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
use messages in some rules, to help to support the localization of error messages.
Is there anything you'd like reviewers to focus on?
I plan to separate it to 4 PRs. temporally disabled the rule, and will enable it when all the changes finished.