Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: babel-code-frame to version 7 #10808

Merged
merged 1 commit into from Aug 29, 2018
Merged

Upgrade: babel-code-frame to version 7 #10808

merged 1 commit into from Aug 29, 2018

Conversation

realityking
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Bumping babel-code-frame to version 7. Note I didn't touch the babel version used in the build process, only code-frame.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 28, 2018
@kaicataldo kaicataldo added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Aug 28, 2018
@kaicataldo
Copy link
Member

Hi, thanks for the PR. Do you mind changing the commit title to start with Upgrade instead of Chore, as outlined in our contribution docs?

@realityking
Copy link
Contributor Author

My bad. Fixed!

Looks like GitHub has issues updating PRs right now, might be a bit until this shows up correctly.

@kaicataldo kaicataldo changed the title Update babel-code-frame to version 7 Ugrade: babel-code-frame to version 7 Aug 28, 2018
kaicataldo
kaicataldo previously approved these changes Aug 28, 2018
View reviewed changes
@kaicataldo
Copy link
Member

This LGTM. Thanks for contributing!

@kaicataldo
Copy link
Member

Ah, actually, just had a thought. I wonder if this will interfere with the release process at all since this version won't match the Babel version we use for our browser bundle. Can you confirm this works when running the bundling step?

@kaicataldo kaicataldo dismissed their stale review August 28, 2018 15:56

Follow up question

@realityking
Copy link
Contributor Author

Running npm run browserify does work. The code doesn't really interact, as code-frame is completely unrelated to the bundling itself.

Any idea why the commit-message check failed?

@gyandeeps
Copy link
Member

Ugrade -> Upgrade: missing p. 😄

@kaicataldo kaicataldo changed the title Ugrade: babel-code-frame to version 7 Upgrade: babel-code-frame to version 7 Aug 28, 2018
@realityking
Copy link
Contributor Author

🤦‍♂️

Fixed.

kaicataldo
kaicataldo approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the commit message typo this LGTM. Thanks for contributing!

@kaicataldo
Copy link
Member

@realityking It doesn't look like the change made it to GitHub

@realityking
Copy link
Contributor Author

I've pushed a commit with the correct message but GitHub has some trouble updating PRs. Might be a bit until it shows up.

@realityking
Copy link
Contributor Author

Now GitHub caught up :)

@realityking
Copy link
Contributor Author

Could someone restart the Travis build? Something timed out on the Node,js 6 build.

not-an-aardvark
not-an-aardvark approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 2b2f11d into eslint:master Aug 29, 2018
@realityking realityking deleted the babel-code-frame branch August 29, 2018 12:16
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 26, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@gyandeeps gyandeeps gyandeeps approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion upgrade This change is related to a dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@realityking @kaicataldo @gyandeeps @platinumazure @not-an-aardvark