Fix: Do not strip underscores in camelcase allow (fixes #11000) #11001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
platinumazure
requested changes
Oct 21, 2018
|
yep, done |
not-an-aardvark
added
bug
|
@platinumazure please can you re review now I added a test? |
platinumazure
approved these changes
Oct 31, 2018
|
Any idea how I can get a second review? |
|
@lukeapage Hope and pray, I guess? Just kidding. I'll ask for another review in our team chat. Thank you for following up! |
nzakas
approved these changes
Nov 28, 2018
|
@lukeapage Merged, thanks for contributing! (And I do apologize for the long delay.) |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
refactor when the name is stripped so it doesn't affect the allow option
Is there anything you'd like reviewers to focus on?