New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Add sort-imports ignoreDeclarationSort (fixes #11019) #11040
Conversation
This allows users to enforce sorting import members, without having to enforce sorting of import declarations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We do need a couple other reviews in order to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some small documentation changes, but the code and tests look good to me. Thanks!
@@ -136,6 +138,34 @@ import c from 'baz.js'; | |||
|
|||
Default is `false`. | |||
|
|||
### `ignoreDeclarationSort` | |||
|
|||
Ignores the sorting of import declaration statements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note that the default is false here. (I see the note below, but I think it's important enough to be included in the intro/summary of the section.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to keep it at the end for consistency with the other sections.
Please let me know if this really needs to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for explaining the rationale. I don't like the location of that info still but it can be fixed in a separate PR. I have no objections to this landing as is. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
```js | ||
/*eslint sort-imports: ["error", { "ignoreDeclarationSort": false }]*/ | ||
import 'foo.js' | ||
import 'bar.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This examples of incorrect code wasn't warned: https://eslint.org/demo/#eyJ0ZXh0IjoiLyplc2xpbnQgc29ydC1pbXBvcnRzOiBbXCJlcnJvclwiLCB7IFwiaWdub3JlRGVjbGFyYXRpb25Tb3J0XCI6IGZhbHNlIH1dKi9cclxuaW1wb3J0ICdmb28uanMnXHJcbmltcG9ydCAnYmFyLmpzJ1xyXG4iLCJvcHRpb25zIjp7InBhcnNlck9wdGlvbnMiOnsiZWNtYVZlcnNpb24iOjgsInNvdXJjZVR5cGUiOiJtb2R1bGUiLCJlY21hRmVhdHVyZXMiOnt9fSwicnVsZXMiOnt9LCJlbnYiOnt9fX0=
Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I fixed it in #11242.
This allows users to enforce sorting import members, without having to enforce
sorting of import declarations.
fixes #11019