Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix invalid super() calls in tests #11054

Merged
merged 1 commit into from Nov 6, 2018
Merged

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Acorn now reports parsing errors for invalid uses of the super keyword, and some tests are failing on master as a result. This commit updates the affected tests as necessary (or removes them if they're no longer applicable).

Is there anything you'd like reviewers to focus on?

Nothing in particular

Acorn now reports parsing errors for invalid uses of the `super` keyword, and some tests are failing on master as a result. This commit updates the affected tests as necessary (or removes them if they're no longer applicable).
@not-an-aardvark not-an-aardvark added bug ESLint is working incorrectly build This change relates to ESLint's build process accepted There is consensus among the team that this change meets the criteria for inclusion labels Nov 5, 2018
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@not-an-aardvark not-an-aardvark merged commit 0800b20 into master Nov 6, 2018
@not-an-aardvark not-an-aardvark deleted the fix-super branch November 6, 2018 00:07
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 6, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants